Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(599)

Issue 29716557: Issue 6220 - add appveyor configuration for adblockpluscore [emscripten] (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
6 months, 2 weeks ago by sergei
Modified:
6 months, 1 week ago
Base URL:
github.com:adblockplus/adblockpluscore
Visibility:
Public.

Description

Add a workaround for unresolved `std::locale::id std::codecvt<char16_t,char,struct _Mbstatet>::id` in MS Visual Studio.

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+42 lines, -0 lines) Patch
A appveyor.yml View 1 chunk +36 lines, -0 lines 0 comments Download
compiled/String.h View 1 chunk +6 lines, -0 lines 0 comments Download

Messages

Total messages: 8
sergei
6 months, 2 weeks ago (2018-03-07 10:35:24 UTC) #1
hub
the C++ change: LGTM the appveyor config, no idea.
6 months, 2 weeks ago (2018-03-07 16:48:19 UTC) #2
sergei
@Oleksandr, tlucas could you please take a look at it? It would be very helpful ...
6 months, 1 week ago (2018-03-13 16:47:00 UTC) #3
tlucas
On 2018/03/13 16:47:00, sergei wrote: > @Oleksandr, tlucas could you please take a look at ...
6 months, 1 week ago (2018-03-13 19:39:16 UTC) #4
Oleksandr
Is the C++ change really relevant here? If so, can you please comment on why ...
6 months, 1 week ago (2018-03-13 20:48:06 UTC) #5
sergei
On 2018/03/13 20:48:06, Oleksandr wrote: > Is the C++ change really relevant here? If so, ...
6 months, 1 week ago (2018-03-14 10:08:01 UTC) #6
shoniko
LGTM
6 months, 1 week ago (2018-03-14 10:22:41 UTC) #7
Oleksandr
6 months, 1 week ago (2018-03-14 10:23:17 UTC) #8
LGTM
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld 87257f5