Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(76)

Issue 29716584: Issue 6451 - Generate $csp exception filters properly (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
1 year, 8 months ago by kzar
Modified:
1 year, 8 months ago
Reviewers:
Thomas Greiner
CC:
Sebastian Noack
Visibility:
Public.

Description

Issue 6451 - Generate $csp exception filters properly

Patch Set 1 #

Total comments: 2

Patch Set 2 : Lowercase the $csp option #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -0 lines) Patch
M devtools-panel.js View 1 1 chunk +3 lines, -0 lines 0 comments Download

Messages

Total messages: 4
kzar
Patch Set 1
1 year, 8 months ago (2018-03-07 14:14:46 UTC) #1
Thomas Greiner
https://codereview.adblockplus.org/29716584/diff/29716585/devtools-panel.js File devtools-panel.js (right): https://codereview.adblockplus.org/29716584/diff/29716585/devtools-panel.js#newcode53 devtools-panel.js:53: options.push("CSP"); Detail: I know that filter options are case ...
1 year, 8 months ago (2018-03-07 14:34:44 UTC) #2
kzar
Patch Set 2 : Lowercase the $csp option https://codereview.adblockplus.org/29716584/diff/29716585/devtools-panel.js File devtools-panel.js (right): https://codereview.adblockplus.org/29716584/diff/29716585/devtools-panel.js#newcode53 devtools-panel.js:53: options.push("CSP"); ...
1 year, 8 months ago (2018-03-07 15:11:40 UTC) #3
Thomas Greiner
1 year, 8 months ago (2018-03-07 15:13:09 UTC) #4
LGTM
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld 87257f5