Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code

Issue 29716660: Fixes #5 - Update home page hero unit (Closed)

Created:
March 7, 2018, 8:01 p.m. by juliandoucette
Modified:
March 9, 2018, 2:36 p.m.
Reviewers:
saroyanm
CC:
ire
Base URL:
https://hg.adblockplus.org/web.adblockplus.org
Visibility:
Public.

Description

## Background https://gitlab.com/eyeo/websites/web.adblockplus.org/issues/5 ## Technical details - This patchset applies to the index_page branch of web.adblockplus.org - This patchset is a work-in-progress as it's specification is incomplete - This draft implements the no-script state of this section - Implementation of this section includes the implementation of the base page (switching from one page per browser to *just* one page) - The video component has been developed further in the master branch, as a result I have left it as-is until I rebase and replace it later

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+229 lines, -1124 lines) Patch
A includes/as-mentioned-on.tmpl View 1 chunk +63 lines, -0 lines 0 comments Download
M includes/features.html View 1 chunk +1 line, -1 line 0 comments Download
A includes/hero-download.html View 1 chunk +37 lines, -0 lines 0 comments Download
R includes/index.tmpl View 1 chunk +0 lines, -230 lines 0 comments Download
M includes/mobile-cross-promotion.tmpl View 0 chunks +-1 lines, --1 lines 0 comments Download
R pages/android.md View 1 chunk +0 lines, -1 line 0 comments Download
R pages/chrome.md View 1 chunk +0 lines, -1 line 0 comments Download
R pages/edge.md View 1 chunk +0 lines, -1 line 0 comments Download
R pages/firefox.md View 1 chunk +0 lines, -1 line 0 comments Download
M pages/index.html View 1 chunk +9 lines, -19 lines 0 comments Download
R pages/internet-explorer.md View 1 chunk +0 lines, -1 line 0 comments Download
R pages/maxthon.md View 1 chunk +0 lines, -1 line 0 comments Download
R pages/opera.md View 1 chunk +0 lines, -1 line 0 comments Download
R pages/safari.md View 1 chunk +0 lines, -1 line 0 comments Download
R pages/yandex-browser.md View 1 chunk +0 lines, -1 line 0 comments Download
M static/css/index.css View 5 chunks +120 lines, -585 lines 0 comments Download
R static/css/index-desktop.css View 1 chunk +0 lines, -138 lines 0 comments Download
R static/css/index-mobile.css View 1 chunk +0 lines, -139 lines 0 comments Download
M templates/default.tmpl View 1 chunk +0 lines, -4 lines 0 comments Download

Messages

Total messages: 3
juliandoucette
March 7, 2018, 8:01 p.m. (2018-03-07 20:01:21 UTC) #1
juliandoucette
Hey Manvel! :) I added you as a reviewer - but you should probably hold ...
March 7, 2018, 8:11 p.m. (2018-03-07 20:11:18 UTC) #2
juliandoucette
March 9, 2018, 2:35 p.m. (2018-03-09 14:35:53 UTC) #3
Done https://hg.adblockplus.org/web.adblockplus.org/rev/1d8bf7725f3b.

I met with Jeen 1 on 1 to demo this change and discuss outstanding issues with
this section and others on this page. I have complied her suggestions into a
document that I will now convert to one or more tickets and address separately
using this change as a base.

Detail: The merge change that follows this one provides an updated video
component for this section.

Powered by Google App Engine
This is Rietveld