Issue 29716720: Noissue - Prepare for absolute paths in flake8-per-file-ignores 0.5 (buildtools)

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 29716720: Noissue - Prepare for absolute paths in flake8-per-file-ignores 0.5 (buildtools) (Closed)

Created:
March 7, 2018, 11:16 p.m. by Sebastian Noack

Modified:
March 8, 2018, 4:06 p.m.

Reviewers:
tlucas

CC:
Vasily Kuznetsov

Visibility:
Public.

Description

Noissue - Prepare for absolute paths in flake8-per-file-ignores 0.5 (buildtools)

Patch Set 1 #

Created: March 7, 2018, 11:16 p.m.

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+8 lines, -8 lines)			Patch
	M	tox.ini	View		2 chunks	+8 lines, -8 lines	0 comments	Download

Messages

Total messages: 2

Expand All Messages | Collapse All Messages

Sebastian Noack

With the next version of flake8-per-file-ignores, absolute paths must be indicated with a leading slash: ...

March 7, 2018, 11:23 p.m. (2018-03-07 23:23:27 UTC) #1

tlucas

March 8, 2018, 9:56 a.m. (2018-03-08 09:56:44 UTC) #2

On 2018/03/07 23:23:27, Sebastian Noack wrote:
> With the next version of flake8-per-file-ignores, absolute paths must be
> indicated with a leading slash:
> https://github.com/snoack/flake8-per-file-ignores/pull/6
> 
> Previously, all paths were considered absolute, and since version 0.4, leading
> slashes were ignored. So if we now add leading slashes, and require at least
> version 0.4, the behavior will remain the same once 0.5 is released.

LGTM

Expand All Messages | Collapse All Messages