Issue 29719572: Issue 6465 - Maintain separate long-term cache in CombinedMatcher

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 29719572: Issue 6465 - Maintain separate long-term cache in CombinedMatcher (Closed)

Created:
March 10, 2018, 11:09 p.m. by Manish Jethani

Modified:
May 15, 2018, 8:43 a.m.

Reviewers:
sergei, kzar

CC:
hub

Base URL:
https://hg.adblockplus.org/adblockpluscore/

Visibility:
Public.

Description

This builds on https://codereview.adblockplus.org/29719569/ See description in Trac #6465.

Patch Set 1 #

Patch Set 2 : Use separate Cache class #

Created: March 11, 2018, 12:13 a.m.

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+39 lines, -5 lines)			Patch
	M	lib/matcher.js	View	1	4 chunks	+39 lines, -5 lines	0 comments	Download

Messages

Total messages: 5

Expand All Messages | Collapse All Messages

Manish Jethani

Patch Set 1 This builds on https://codereview.adblockplus.org/29719569/ See description in Trac #6465.

March 10, 2018, 11:11 p.m. (2018-03-10 23:11:31 UTC) #2

kzar

The change itself looks OK to me, and it's certainly an interesting idea which is ...

April 18, 2018, 3:10 p.m. (2018-04-18 15:10:05 UTC) #4

Manish Jethani

May 15, 2018, 8:43 a.m. (2018-05-15 08:43:42 UTC) #5

Message was sent while issue was closed.

I have closed this for now so as not to clutter the reviewers' incoming reviews
list. I may revisit this at some point. In any case the Trac issue is still open
and worth looking further into, whenever someone has the time.

Expand All Messages | Collapse All Messages