Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code

Issue 29720604: Issue 6405 - Remove CircleCI refs. (Closed)

Created:
March 12, 2018, 3:21 p.m. by a.shephard
Modified:
March 15, 2018, 8:09 a.m.
Reviewers:
d108, dean
Visibility:
Public.

Description

Issue 6405 - Remove build scripts, CircleCI refs

Patch Set 1 #

Patch Set 2 : Issue 6405 - Remove build scripts & CircleCI refs. Removed Cartfile reference #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -425 lines) Patch
M AdblockBrowser.xcodeproj/project.pbxproj View 1 6 chunks +0 lines, -26 lines 0 comments Download
D circle.yml View 1 chunk +0 lines, -86 lines 0 comments Download
D deploy/ExportOptions.plist View 1 chunk +0 lines, -34 lines 0 comments Download
D deploy/build.sh View 1 chunk +0 lines, -120 lines 0 comments Download
D deploy/carthage-bootstrap.sh View 1 chunk +0 lines, -21 lines 0 comments Download
D deploy/checkout-core.sh View 1 chunk +0 lines, -59 lines 0 comments Download
D deploy/hockey.sh View 1 chunk +0 lines, -36 lines 0 comments Download
D e2e_tests.sh View 1 chunk +0 lines, -16 lines 0 comments Download
D package.json View 1 chunk +0 lines, -6 lines 0 comments Download
D run_as_circle.sh View 1 chunk +0 lines, -21 lines 0 comments Download

Messages

Total messages: 5
a.shephard
NOTE: This also affects ticket 6406 - Cleaning Build Scripts. Removed the build scripts, the ...
March 12, 2018, 3:25 p.m. (2018-03-12 15:25:37 UTC) #1
dean
On 2018/03/12 15:25:37, a.shephard wrote: > NOTE: This also affects ticket 6406 - Cleaning Build ...
March 13, 2018, 1:22 p.m. (2018-03-13 13:22:11 UTC) #2
d108
The Cartfile doesn't need to be added to the Xcode project. We did not add ...
March 14, 2018, 1:56 a.m. (2018-03-14 01:56:53 UTC) #3
a.shephard
Acknowledged. Removed the Cartfile reference from the project.
March 14, 2018, 9:01 a.m. (2018-03-14 09:01:13 UTC) #4
d108
March 14, 2018, 10 p.m. (2018-03-14 22:00:05 UTC) #5
On 2018/03/14 09:01:13, a.shephard wrote:
> Acknowledged. Removed the Cartfile reference from the project.

LGTM

Powered by Google App Engine
This is Rietveld