Issue 29720604: Issue 6405 - Remove CircleCI refs.

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 29720604: Issue 6405 - Remove CircleCI refs. (Closed)

Created:
March 12, 2018, 3:21 p.m. by a.shephard

Modified:
March 15, 2018, 8:09 a.m.

Reviewers:
d108, dean

Visibility:
Public.

Issue 6405 - Remove build scripts, CircleCI refs

Created: March 14, 2018, 8:58 a.m.

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+0 lines, -425 lines)			Patch
M	AdblockBrowser.xcodeproj/project.pbxproj	View	1	6 chunks	+0 lines, -26 lines	0 comments	Download
D	circle.yml	View		1 chunk	+0 lines, -86 lines	0 comments	Download
D	deploy/ExportOptions.plist	View		1 chunk	+0 lines, -34 lines	0 comments	Download
D	deploy/build.sh	View		1 chunk	+0 lines, -120 lines	0 comments	Download
D	deploy/carthage-bootstrap.sh	View		1 chunk	+0 lines, -21 lines	0 comments	Download
D	deploy/checkout-core.sh	View		1 chunk	+0 lines, -59 lines	0 comments	Download
D	deploy/hockey.sh	View		1 chunk	+0 lines, -36 lines	0 comments	Download
D	e2e_tests.sh	View		1 chunk	+0 lines, -16 lines	0 comments	Download
D	package.json	View		1 chunk	+0 lines, -6 lines	0 comments	Download
D	run_as_circle.sh	View		1 chunk	+0 lines, -21 lines	0 comments	Download

Total messages: 5

a.shephard

NOTE: This also affects ticket 6406 - Cleaning Build Scripts. Removed the build scripts, the ...

March 12, 2018, 3:25 p.m. (2018-03-12 15:25:37 UTC) #1

dean

On 2018/03/12 15:25:37, a.shephard wrote: > NOTE: This also affects ticket 6406 - Cleaning Build ...

March 13, 2018, 1:22 p.m. (2018-03-13 13:22:11 UTC) #2

d108

The Cartfile doesn't need to be added to the Xcode project. We did not add ...

March 14, 2018, 1:56 a.m. (2018-03-14 01:56:53 UTC) #3

a.shephard

Acknowledged. Removed the Cartfile reference from the project.

March 14, 2018, 9:01 a.m. (2018-03-14 09:01:13 UTC) #4

d108

March 14, 2018, 10 p.m. (2018-03-14 22:00:05 UTC) #5

On 2018/03/14 09:01:13, a.shephard wrote:
> Acknowledged. Removed the Cartfile reference from the project.

LGTM