Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code
Issues
All Issues

Issue 29720642: Noissue - Added .body-container to provide padding-top for body content and avoid navbar overlap (Closed)

Created:
March 12, 2018, 5:02 p.m. by juliandoucette
Modified:
March 13, 2018, 12:37 p.m.
Reviewers:
ire
Base URL:
https://hg.adblockplus.org/web.adblockplus.org
Visibility:
Public.

Description

Noissue - Added .body-container to provide padding-top for body content and avoid navbar overlap

Patch Set 1 #

Total comments: 7

Patch Set 2 : Moved space to <body> #

Total comments: 2
Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -2 lines) Patch
M static/css/index.css View 1 1 chunk +1 line, -1 line 0 comments Download
M static/css/main.css View 1 1 chunk +1 line, -1 line 2 comments Download

Messages

Total messages: 7
juliandoucette
March 12, 2018, 5:02 p.m. (2018-03-12 17:02:20 UTC) #1
juliandoucette
I made this change while I was addressing web.adblockplus.org#30 and decided to submit it for ...
March 12, 2018, 5:08 p.m. (2018-03-12 17:08:19 UTC) #2
ire
Thanks Julian! A couple of comments/NITs https://codereview.adblockplus.org/29720642/diff/29720643/static/css/main.css File static/css/main.css (right): https://codereview.adblockplus.org/29720642/diff/29720643/static/css/main.css#newcode14 static/css/main.css:14: .body-container NIT: We ...
March 13, 2018, 8:31 a.m. (2018-03-13 08:31:36 UTC) #3
juliandoucette
Thanks Ire!! New patchset up! https://codereview.adblockplus.org/29720642/diff/29720643/static/css/main.css File static/css/main.css (right): https://codereview.adblockplus.org/29720642/diff/29720643/static/css/main.css#newcode14 static/css/main.css:14: .body-container On 2018/03/13 08:31:36, ...
March 13, 2018, 12:14 p.m. (2018-03-13 12:14:04 UTC) #4
ire
LGTM + NIT https://codereview.adblockplus.org/29720642/diff/29721560/static/css/main.css File static/css/main.css (right): https://codereview.adblockplus.org/29720642/diff/29721560/static/css/main.css#newcode10 static/css/main.css:10: padding-top: 4em; NIT: It could be ...
March 13, 2018, 12:24 p.m. (2018-03-13 12:24:48 UTC) #5
juliandoucette
Will-do. https://codereview.adblockplus.org/29720642/diff/29721560/static/css/main.css File static/css/main.css (right): https://codereview.adblockplus.org/29720642/diff/29721560/static/css/main.css#newcode10 static/css/main.css:10: padding-top: 4em; On 2018/03/13 12:24:48, ire wrote: > ...
March 13, 2018, 12:32 p.m. (2018-03-13 12:32:54 UTC) #6
juliandoucette
March 13, 2018, 12:37 p.m. (2018-03-13 12:37:06 UTC) #7

Powered by Google App Engine
This is Rietveld