templates/minimal.tmpl - Issue 29720642: Noissue - Added .body-container to provide padding-top for body content and avoid navbar overlap

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments.

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Side by Side Diff: templates/minimal.tmpl

Issue 29720642: Noissue - Added .body-container to provide padding-top for body content and avoid navbar overlap (Closed) Base URL: https://hg.adblockplus.org/web.adblockplus.org

Patch Set: Created March 12, 2018, 5:02 p.m.

Left:
Right:

Use n/p to move between diff chunks; N/P to move between comments.

Jump to:

View unified diff | Download patch

OLD	NEW
1 {#	1 {#

2 # This file is part of the Adblock Plus website,	2 # This file is part of the Adblock Plus website,

3 # Copyright (C) 2006-present eyeo GmbH	3 # Copyright (C) 2006-present eyeo GmbH

4 #	4 #

5 # Adblock Plus is free software: you can redistribute it and/or modify	5 # Adblock Plus is free software: you can redistribute it and/or modify

6 # it under the terms of the GNU General Public License version 3 as	6 # it under the terms of the GNU General Public License version 3 as

7 # published by the Free Software Foundation.	7 # published by the Free Software Foundation.

8 #	8 #

9 # Adblock Plus is distributed in the hope that it will be useful,	9 # Adblock Plus is distributed in the hope that it will be useful,

10 # but WITHOUT ANY WARRANTY; without even the implied warranty of	10 # but WITHOUT ANY WARRANTY; without even the implied warranty of

(...skipping 14 matching lines...) Expand all Loading...
25 <? include polyfills ?>	25 <? include polyfills ?>

26	26

27 {% block head %}	27 {% block head %}

28 {{ head \| safe }}	28 {{ head \| safe }}

29 {% endblock %}	29 {% endblock %}

30 </head>	30 </head>

31	31

32 <body>	32 <body>

33 <? include navbar ?>	33 <? include navbar ?>

34	34

	35 <div class="body-container">
	juliandoucette 2018/03/12 17:08:19 NIT: I think that this could/should be an ID to be NIT: I think that this could/should be an ID to be consistent with our implementation style elsewhere (although I personally prefer it as a class). ire 2018/03/13 08:31:36 I think it should be an ID too. Also to enforce th Show quoted text On 2018/03/12 17:08:19, juliandoucette wrote: > NIT: I think that this could/should be an ID to be consistent with our > implementation style elsewhere (although I personally prefer it as a class). I think it should be an ID too. Also to enforce that it should only be on a page once. juliandoucette 2018/03/13 12:14:04 Acknowledged. Show quoted text On 2018/03/13 08:31:36, ire wrote: > On 2018/03/12 17:08:19, juliandoucette wrote: > > NIT: I think that this could/should be an ID to be consistent with our > > implementation style elsewhere (although I personally prefer it as a class). > > I think it should be an ID too. Also to enforce that it should only be on a page > once. Acknowledged.
35 {% block body %}	36 {% block body %}

36 {{ body \| safe }}	37 {{ body \| safe }}

37 {% endblock %}	38 {% endblock %}

	39 </div>

38	40

39 <? include footer ?>	41 <? include footer ?>

40 <? include scripts ?>	42 <? include scripts ?>

41 </body>	43 </body>

42 </html>	44 </html>

OLD	NEW

« templates/default.tmpl ('K') | « templates/default.tmpl ('k') | no next file » | no next file with comments »