Issue 6180 - use ABP_TEXT everywhere in order to let String be a UTF-8 string

compiled/subscription/Subscription.cpp

 /*
  * This file is part of Adblock Plus <https://adblockplus.org/>,
  * Copyright (C) 2006-present eyeo GmbH
  *
  * Adblock Plus is free software: you can redistribute it and/or modify
  * it under the terms of the GNU General Public License version 3 as
  * published by the Free Software Foundation.
  *
  * Adblock Plus is distributed in the hope that it will be useful,
  * but WITHOUT ANY WARRANTY; without even the implied warranty of
@@ skipping 43 matching lines @@
 int Subscription::IndexOfFilter(const Filter& filter)
 {
   for (Filters::size_type i = 0; i < mFilters.size(); i++)
     if (mFilters[i] == &filter)
       return i;
   return -1;
 }
 
 OwnedString Subscription::Serialize() const
 {
-  OwnedString result(u"[Subscription]\nurl="_str);
+  OwnedString result(ABP_TEXT("[Subscription]\nurl="_str));
   result.append(mID);
-  result.append(u'\n');
+  result.append(ABP_TEXT('\n'));
   if (!mTitle.empty())
   {
-    result.append(u"title="_str);
+    result.append(ABP_TEXT("title="_str));
     result.append(mTitle);
-    result.append(u'\n');
+    result.append(ABP_TEXT('\n'));
   }
   if (mDisabled)
-    result.append(u"disabled=true\n"_str);
+    result.append(ABP_TEXT("disabled=true\n"_str));
 
   return result;
 }
 
 OwnedString Subscription::SerializeFilters() const
 {
   if (!mFilters.size())
     return OwnedString();
 
-  OwnedString result(u"[Subscription filters]\n"_str);
+  OwnedString result(ABP_TEXT("[Subscription filters]\n"_str));
   for (const auto& filter : mFilters)
   {
     // TODO: Escape [ characters
     result.append(filter->GetText());
-    result.append(u'\n');
+    result.append(ABP_TEXT('\n'));
   }
   return result;
 }
 
 Subscription* Subscription::FromID(const String& id)
 {
   if (id.empty())
   {
     // Generate a new random ID
     std::mt19937 gen(knownSubscriptions.size());
-    OwnedString randomID(u"~user~000000"_str);
+    OwnedString randomID(ABP_TEXT("~user~000000"_str));
     do
     {
       int number = gen();
       for (String::size_type i = randomID.length() - 6; i < randomID.length(); i++)
       {
-        randomID[i] = '0' + (number % 10);
+        randomID[i] = ABP_TEXT('0') + (number % 10);
         number /= 10;
       }
     } while (knownSubscriptions.find(randomID));
     return FromID(randomID);
   }
 
   auto knownSubscription = knownSubscriptions.find(id);
   if (knownSubscription)
   {
     knownSubscription->second->AddRef();
     return knownSubscription->second;
   }
 
   SubscriptionPtr subscription;
-  if (!id.empty() && id[0] == '~')
+  if (!id.empty() && id[0] == ABP_TEXT('~'))
     subscription = SubscriptionPtr(new UserDefinedSubscription(id), false);
   else
     subscription = SubscriptionPtr(new DownloadableSubscription(id), false);
 
   // This is a hack: we looked up the entry using id but create it using
   // subscription->mID. This works because both are equal at this point.
   // However, id refers to a temporary buffer which will go away.
   enter_context("Adding to known subscriptions");
   knownSubscription.assign(subscription->mID, subscription.get());
   exit_context();
 
   return subscription.release();
 }