Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code
Issues
All Issues

Issue 29721753: Issue 6180 - use ABP_TEXT everywhere in order to let String be a UTF-8 string (Closed)

Created:
March 13, 2018, 6:20 p.m. by sergei
Modified:
March 15, 2018, 3:53 p.m.
Base URL:
https://github.com/adblockplus/adblockpluscore.git@adb2678354813ce5b6de095072954c5a784a7bc4
Visibility:
Public.

Description

It's merely the first step, e.g. the implementation of String::toLower is not affected yet.

Patch Set 1 #

Total comments: 2

Patch Set 2 : rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+307 lines, -279 lines) Patch
M .travis/travis-script.sh View 1 chunk +5 lines, -0 lines 0 comments Download
M compiled/ElemHide.cpp View 1 chunk +2 lines, -2 lines 0 comments Download
M compiled/Map.h View 1 chunk +2 lines, -2 lines 0 comments Download
M compiled/String.h View 1 11 chunks +35 lines, -14 lines 0 comments Download
M compiled/String.cpp View 1 chunk +2 lines, -2 lines 0 comments Download
M compiled/StringScanner.h View 1 chunk +1 line, -1 line 0 comments Download
M compiled/filter/ActiveFilter.cpp View 8 chunks +12 lines, -12 lines 0 comments Download
M compiled/filter/CommentFilter.cpp View 1 chunk +1 line, -1 line 0 comments Download
M compiled/filter/ElemHideBase.cpp View 14 chunks +30 lines, -30 lines 0 comments Download
M compiled/filter/Filter.cpp View 5 chunks +7 lines, -7 lines 0 comments Download
M compiled/filter/RegExpFilter.cpp View 15 chunks +63 lines, -63 lines 0 comments Download
M compiled/intrusive_ptr.h View 2 chunks +2 lines, -2 lines 0 comments Download
M compiled/library.cpp View 1 chunk +1 line, -1 line 0 comments Download
M compiled/storage/FilterStorage.cpp View 1 chunk +1 line, -1 line 0 comments Download
M compiled/subscription/DownloadableSubscription.cpp View 1 chunk +23 lines, -23 lines 0 comments Download
M compiled/subscription/Subscription.cpp View 4 chunks +10 lines, -10 lines 0 comments Download
M compiled/subscription/UserDefinedSubscription.cpp View 1 chunk +5 lines, -5 lines 0 comments Download
M test/compiled/Filter.cpp View 1 chunk +15 lines, -15 lines 0 comments Download
M test/compiled/RegExp.cpp View 1 chunk +5 lines, -5 lines 0 comments Download
M test/compiled/String.cpp View 2 chunks +69 lines, -69 lines 0 comments Download
M test/compiled/StringMap.cpp View 1 chunk +13 lines, -13 lines 0 comments Download
A + test/compiled/user-config-test-abp-utf8-string.h View 1 chunk +3 lines, -1 line 0 comments Download

Messages

Total messages: 6
sergei
March 13, 2018, 6:29 p.m. (2018-03-13 18:29:01 UTC) #1
hub
https://codereview.adblockplus.org/29721753/diff/29721754/compiled/String.h File compiled/String.h (right): https://codereview.adblockplus.org/29721753/diff/29721754/compiled/String.h#newcode42 compiled/String.h:42: #define ABP_TEXT(val) val Can't we make this macro shorter? ...
March 13, 2018, 9:29 p.m. (2018-03-13 21:29:16 UTC) #2
sergei
https://codereview.adblockplus.org/29721753/diff/29721754/compiled/String.h File compiled/String.h (right): https://codereview.adblockplus.org/29721753/diff/29721754/compiled/String.h#newcode42 compiled/String.h:42: #define ABP_TEXT(val) val On 2018/03/13 21:29:16, hub wrote: > ...
March 14, 2018, 10:17 a.m. (2018-03-14 10:17:11 UTC) #3
hub
LGTM
March 14, 2018, 2:54 p.m. (2018-03-14 14:54:15 UTC) #4
sergei
I had to rebase it.
March 15, 2018, 1:54 p.m. (2018-03-15 13:54:46 UTC) #5
hub
March 15, 2018, 2:16 p.m. (2018-03-15 14:16:41 UTC) #6 
LGTM

Powered by Google App Engine
This is Rietveld