compiled/filter/CommentFilter.cpp - Issue 29721753: Issue 6180 - use ABP_TEXT everywhere in order to let String be a UTF-8 string

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Unified Diff: compiled/filter/CommentFilter.cpp

Issue 29721753: Issue 6180 - use ABP_TEXT everywhere in order to let String be a UTF-8 string (Closed) Base URL: https://github.com/adblockplus/adblockpluscore.git@adb2678354813ce5b6de095072954c5a784a7bc4

Patch Set: rebase Created March 15, 2018, 1:53 p.m.

Use n/p to move between diff chunks; N/P to move between comments.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: compiled/filter/CommentFilter.cpp

diff --git a/compiled/filter/CommentFilter.cpp b/compiled/filter/CommentFilter.cpp

index b55db264ece931669a186f52415d0be95896b0ee..c3747d018992e1a544f3edea79a6748fe70b7f7e 100644

--- a/compiled/filter/CommentFilter.cpp

+++ b/compiled/filter/CommentFilter.cpp

@@ -26,7 +26,7 @@ CommentFilter::CommentFilter(const String& text)

Filter::Type CommentFilter::Parse(const String& text)

{

- if (text.length() && text[0] == u'!')

+ if (text.length() && text[0] == ABP_TEXT('!'))

return Type::COMMENT;

else

return Type::UNKNOWN;

« no previous file with comments | « compiled/filter/ActiveFilter.cpp ('k') | compiled/filter/ElemHideBase.cpp » ('j') | no next file with comments »