compiled/intrusive_ptr.h - Issue 29721753: Issue 6180 - use ABP_TEXT everywhere in order to let String be a UTF-8 string

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Unified Diff: compiled/intrusive_ptr.h

Issue 29721753: Issue 6180 - use ABP_TEXT everywhere in order to let String be a UTF-8 string (Closed) Base URL: https://github.com/adblockplus/adblockpluscore.git@adb2678354813ce5b6de095072954c5a784a7bc4

Patch Set: rebase Created March 15, 2018, 1:53 p.m.

Use n/p to move between diff chunks; N/P to move between comments.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: compiled/intrusive_ptr.h

diff --git a/compiled/intrusive_ptr.h b/compiled/intrusive_ptr.h

index d09d768b50a3e0df14b4b8c20b31ae4a859ba5da..4ff2aa7ba8f60a43d5fc4a55623174b4abd104ce 100644

--- a/compiled/intrusive_ptr.h

+++ b/compiled/intrusive_ptr.h

@@ -44,7 +44,7 @@ public:

void ReleaseRef()

{

- assert2(mRefCount > 0, u"Unexpected zero or negative reference count"_str);

+ assert2(mRefCount > 0, ABP_TEXT("Unexpected zero or negative reference count"_str));

if (--mRefCount == 0)

delete this;

}

@@ -57,7 +57,7 @@ protected:

virtual ~ref_counted()

{

- assert2(mRefCount == 0, u"Destroying a ref-counted object with a non-zero reference count"_str);

+ assert2(mRefCount == 0, ABP_TEXT("Destroying a ref-counted object with a non-zero reference count"_str));

}

private:

« no previous file with comments | « compiled/filter/RegExpFilter.cpp ('k') | compiled/library.cpp » ('j') | no next file with comments »