Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(600)

Issue 29721780: Fixes #33 - Adjustments to features section of index page (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
6 months, 1 week ago by juliandoucette
Modified:
6 months, 1 week ago
Reviewers:
ire
Base URL:
https://hg.adblockplus.org/web.adblockplus.org
Visibility:
Public.

Description

Fixes #33 - Adjustments to features section of index page

Patch Set 1 #

Total comments: 9

Patch Set 2 : Rebased & Addressed #2 and #3 #

Total comments: 5

Patch Set 3 : Addressed #5 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+88 lines, -32 lines) Patch
M includes/features.html View 1 chunk +11 lines, -11 lines 0 comments Download
M static/css/index.css View 1 2 1 chunk +77 lines, -0 lines 0 comments Download
M static/css/main.css View 1 chunk +0 lines, -21 lines 0 comments Download

Messages

Total messages: 10
juliandoucette
6 months, 1 week ago (2018-03-13 20:44:50 UTC) #1
ire
Thanks Julian! https://codereview.adblockplus.org/29721780/diff/29721781/static/css/index.css File static/css/index.css (right): https://codereview.adblockplus.org/29721780/diff/29721781/static/css/index.css#newcode239 static/css/index.css:239: padding: 0 3em 2em 10.5em; The bottom ...
6 months, 1 week ago (2018-03-14 08:21:39 UTC) #2
ire
https://codereview.adblockplus.org/29721780/diff/29721781/static/css/index.css File static/css/index.css (right): https://codereview.adblockplus.org/29721780/diff/29721781/static/css/index.css#newcode200 static/css/index.css:200: * #features TOL: I'm working on the download page, ...
6 months, 1 week ago (2018-03-14 08:44:01 UTC) #3
juliandoucette
Thanks! New Patchset up! https://codereview.adblockplus.org/29721780/diff/29721781/static/css/index.css File static/css/index.css (right): https://codereview.adblockplus.org/29721780/diff/29721781/static/css/index.css#newcode200 static/css/index.css:200: * #features On 2018/03/14 08:44:01, ...
6 months, 1 week ago (2018-03-14 11:50:38 UTC) #4
ire
Just one more thing https://codereview.adblockplus.org/29721780/diff/29721781/static/css/index.css File static/css/index.css (right): https://codereview.adblockplus.org/29721780/diff/29721781/static/css/index.css#newcode200 static/css/index.css:200: * #features On 2018/03/14 11:50:37, ...
6 months, 1 week ago (2018-03-14 13:07:42 UTC) #5
juliandoucette
Thanks Ire! New Patchset up! https://codereview.adblockplus.org/29721780/diff/29722576/static/css/index.css File static/css/index.css (right): https://codereview.adblockplus.org/29721780/diff/29722576/static/css/index.css#newcode209 static/css/index.css:209: padding-bottom: 3em; On 2018/03/14 ...
6 months, 1 week ago (2018-03-14 13:54:42 UTC) #6
ire
LGTM https://codereview.adblockplus.org/29721780/diff/29722576/static/css/index.css File static/css/index.css (right): https://codereview.adblockplus.org/29721780/diff/29722576/static/css/index.css#newcode234 static/css/index.css:234: text-align: left; On 2018/03/14 13:54:42, juliandoucette wrote: > ...
6 months, 1 week ago (2018-03-14 14:04:35 UTC) #7
juliandoucette
Done https://hg.adblockplus.org/web.adblockplus.org/rev/8e2aaa2f35f1
6 months, 1 week ago (2018-03-14 14:55:12 UTC) #8
juliandoucette
Undone https://hg.adblockplus.org/web.adblockplus.org/rev/f75d9970d569 :P
6 months, 1 week ago (2018-03-14 14:59:17 UTC) #9
juliandoucette
6 months, 1 week ago (2018-03-14 15:00:37 UTC) #10

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld 87257f5