Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(128)

Issue 29721785: Fixes #29 - Moved reinstall banner below heading on uninstalled pages (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
3 months ago by juliandoucette
Modified:
3 months ago
Reviewers:
ire
CC:
jeen
Base URL:
https://hg.adblockplus.org/web.adblockplus.org
Visibility:
Public.

Description

Fixes #29 - Moved reinstall banner below heading on uninstalled pages

Patch Set 1 #

Patch Set 2 : Adjusted spacing and refactored button to accomodate other languages #

Total comments: 7

Patch Set 3 : Addressed #3 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+21 lines, -26 lines) Patch
M includes/reinstall.tmpl View 1 1 chunk +2 lines, -6 lines 0 comments Download
M pages/uninstalled.tmpl View 1 chunk +2 lines, -3 lines 0 comments Download
M pages/uninstalled-submit.html View 1 chunk +1 line, -1 line 0 comments Download
M static/css/main.css View 1 1 chunk +2 lines, -1 line 0 comments Download
M static/css/uninstalled.css View 1 2 1 chunk +14 lines, -15 lines 0 comments Download

Messages

Total messages: 7
juliandoucette
3 months ago (2018-03-13 21:12:44 UTC) #1
juliandoucette
CC Jeen I tacked on two minor (but significant) changes. 1. I moved the reinstall ...
3 months ago (2018-03-13 21:46:13 UTC) #2
ire
On 2018/03/13 21:46:13, juliandoucette wrote: > CC Jeen > > I tacked on two minor ...
3 months ago (2018-03-14 08:34:29 UTC) #3
juliandoucette
Thanks Ire! https://codereview.adblockplus.org/29721785/diff/29721791/static/css/uninstalled.css File static/css/uninstalled.css (right): https://codereview.adblockplus.org/29721785/diff/29721791/static/css/uninstalled.css#newcode6 static/css/uninstalled.css:6: font-size: 1.1em; On 2018/03/14 08:34:29, ire wrote: ...
3 months ago (2018-03-14 12:02:27 UTC) #4
ire
LGTM (+NIT) https://codereview.adblockplus.org/29721785/diff/29721791/static/css/uninstalled.css File static/css/uninstalled.css (right): https://codereview.adblockplus.org/29721785/diff/29721791/static/css/uninstalled.css#newcode6 static/css/uninstalled.css:6: font-size: 1.1em; On 2018/03/14 12:02:27, juliandoucette wrote: ...
3 months ago (2018-03-14 13:10:21 UTC) #5
juliandoucette
On 2018/03/14 13:10:21, ire wrote: > > - Because the .lead class is not responsive ...
3 months ago (2018-03-14 13:48:21 UTC) #6
juliandoucette
3 months ago (2018-03-14 13:50:39 UTC) #7

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld 87257f5