Unified Diff: pages/download.tmpl
Issue 29722640:
Fixes #22 - Add download page (Closed)
Base URL: https://hg.adblockplus.org/web.adblockplus.org
Patch Set:
Created March 14, 2018, 1:31 p.m.
Use n/p to move between diff chunks;
N/P to move between comments.
« no previous file with comments
|
« no previous file
|
static/css/main.css » ('j')
|
static/css/main.css » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')
| Index: pages/download.tmpl |
| =================================================================== |
| new file mode 100644 |
| --- /dev/null |
| +++ b/pages/download.tmpl |
| @@ -0,0 +1,88 @@ |
| +title=Download Adblock Plus |
| +description=Get Adblock Plus for free on Firefox, Chrome, Opera, Safari, Android and iOS |
|
ire
2018/03/14 13:34:37
The title & description aren't in the spec yet.
juliandoucette
2018/03/14 17:54:53
Acknowledged.
|
| +template=minimal |
| + |
| +<head> |
| + <style> |
| + header img { |
| + width: 4em; |
| + height: auto; |
| + } |
| + </style> |
| +</head> |
| + |
| +{% set supported_devices = [ |
| + { |
| + "icons": ["device-desktop.png", "device-desktop-2x.png"], |
| + "icon_alt": "Computer monitor and mouse icon", |
| + "title": "Block ads on any desktop browser", |
| + "description": "By clicking any of the links below, you agree to our <a href=\"terms\">Terms of Use</a>", |
|
juliandoucette
2018/03/14 17:54:53
Missing period.
ire
2018/03/15 09:38:12
Done.
|
| + "platforms": [ |
| + { "name": "Chrome", "url": "https://chrome.google.com/webstore/detail/cfhdojbkjhnklbpkdaibdccddilifddb" }, |
| + { "name": "Firefox", "url": "https://update.adblockplus.org/latest/adblockplusfirefox.xpi" }, |
| + { "name": "Internet Explorer", "url": "https://update.adblockplus.org/latest/adblockplusie.exe" }, |
| + { "name": "Safari", "url": "https://update.adblockplus.org/latest/adblockplussafari.safariextz" }, |
| + { "name": "Edge (beta)", "url": "https://www.microsoft.com/store/p/adblock-plus/9nblggh4r9nz" }, |
| + { "name": "Opera", "url": "https://addons.opera.com/extensions/details/opera-adblock/?display=en-US" }, |
| + { "name": "Maxthon", "url": "http://www.maxthon.com/mx5/features/ad-blocker/" }, |
| + { "name": "Yandex Browser", "url": "https://chrome.google.com/webstore/detail/cfhdojbkjhnklbpkdaibdccddilifddb" } |
| + ] |
| + }, |
| + { |
| + "icons": ["device-mobile.png", "device-mobile.svg"], |
| + "icon_alt": "Mobile icon", |
| + "title": "Block ads on your mobile browser", |
| + "platforms": [ |
| + { "name": "Samsung Internet (Android)", "url": "https://play.google.com/store/apps/details?id=org.adblockplus.adblockplussbrowser&hl" }, |
| + { "name": "Safari (iOS)", "url": "https://itunes.apple.com/app/adblock-plus-abp-remove-ads-browse-faster-without-tracking/id1028871868?mt=8" }, |
| + { "name": "Firefox", "url": "https://addons.mozilla.org/android/addon/adblock-plus/" } |
| + ] |
| + }, |
| + { |
| + "icons": ["abb-icon.png", "abb-icon-2x.png"], |
| + "icon_alt": "Adblock Browser logo", |
| + "title": "Block ads in a dedicated ad-blocking browser", |
| + "platforms": [ |
| + { "name": "Adblock Browser (Android)", "url": "https://play.google.com/store/apps/details?id=org.adblockplus.browser" }, |
| + { "name": "Adblock Browser (iOS)", "url": "https://itunes.apple.com/my/app/adblock-browser/id1015653330?mt=8&ign-itsct=1015653330-1015653330&ign-itscg=0176&ign-mpt=uo%3D4" } |
| + ] |
| + } |
| +] %} |
| + |
| +<header class="bg-primary section content text-center"> |
| + <div class="container"> |
| + <img height="90px" |
| + width="90px" |
| + src="/img/download-icon.png" |
| + srcset="/img/download-icon.svg 2x" |
| + alt="White down arrow"> |
|
juliandoucette
2018/03/14 17:54:52
Missing translation.
ire
2018/03/15 09:38:11
Done.
|
| + <h1>{{ "Get Adblock Plus products on these devices" | translate("download-heading") }}</h1> |
|
juliandoucette
2018/03/14 17:54:52
Missing string context (heading).
ire
2018/03/15 09:38:12
Done.
|
| + <p>{{ "Supported platforms" | translate("download-subheading") }}</p> |
|
juliandoucette
2018/03/14 17:54:52
Missing string context (subheading).
ire
2018/03/15 09:38:12
Done.
|
| + </div> |
| +</header> |
| + |
| +<div class="container text-center content"> |
|
juliandoucette
2018/03/14 17:54:52
Suggest: section class?
ire
2018/03/15 09:38:11
That would create a different sectioning context.
|
| + <div class="row item-group"> |
|
ire
2018/03/14 13:34:37
Until we push your features review, I'm using the
juliandoucette
2018/03/14 17:54:52
Acknowledged.
|
| + {% for device in supported_devices %} |
| + <div class="column one-third item"> |
| + <img |
| + height="90px" |
| + width="90px" |
| + src="/img/{{ device.icons[0] }}" |
| + srcset="/img/{{ device.icons[1] }} 2x" |
| + alt="{{ device.icon_alt }}"> |
|
juliandoucette
2018/03/14 17:54:53
Missing translation.
ire
2018/03/15 09:38:11
Done.
|
| + <h2 class="item-heading">{{ device.title }}</h2> |
|
juliandoucette
2018/03/14 17:54:52
Missing translation.
ire
2018/03/15 09:38:11
Done.
|
| + <div class="item-body"> |
| + <p>{{ device.description | safe }}</p> |
|
juliandoucette
2018/03/14 17:54:52
Missing translation.
I didn't know "| safe" was a
ire
2018/03/15 09:38:11
Done.
|
| + <ul class="horizontal-list"> |
|
juliandoucette
2018/03/14 17:54:53
Detail: We may consider optimizing these links usi
|
| + {% for platform in device.platforms %} |
| + <li> |
|
juliandoucette
2018/03/14 17:54:53
See https://gitlab.com/eyeo/specs/spec/merge_reque
ire
2018/03/15 09:38:12
Done.
|
| + <a href="{{ platform.url }}">{{ platform.name }}</a>{{ ", " if loop.index != loop.length }} |
|
juliandoucette
2018/03/14 17:54:52
Missing translation.
juliandoucette
2018/03/14 17:54:52
Detail: We may consider optimizing these link labe
ire
2018/03/15 09:38:11
Done.
|
| + </li> |
| + {% endfor %} |
| + </ul> |
| + </div> |
| + </div> |
| + {% endfor %} |
| + </div> |
| +</div> |
« no previous file with comments
|
« no previous file
|
static/css/main.css » ('j')
|
static/css/main.css » ('J')
