Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code

Issue 29723555: Noissue - Make ext._removeFromAllPageMaps private (Closed)

Created:
March 15, 2018, 6:23 a.m. by Manish Jethani
Modified:
March 15, 2018, 3:42 p.m.
Reviewers:
Sebastian Noack, kzar
Base URL:
https://hg.adblockplus.org/adblockpluschrome/
Visibility:
Public.

Description

Noissue - Make ext._removeFromAllPageMaps private

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+5 lines, -4 lines) Patch
M ext/background.js View 3 chunks +5 lines, -4 lines 0 comments Download

Messages

Total messages: 3
Manish Jethani
March 15, 2018, 6:23 a.m. (2018-03-15 06:23:40 UTC) #1
Manish Jethani
Patch Set 1 This doesn't need to be an ext property.
March 15, 2018, 6:24 a.m. (2018-03-15 06:24:16 UTC) #2
Sebastian Noack
March 15, 2018, 3:40 p.m. (2018-03-15 15:40:06 UTC) #3
LGTM

Powered by Google App Engine
This is Rietveld