Issue 29723596: Issue 6486 - Update Carthage references for external dependencies on GitLab

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 29723596: Issue 6486 - Update Carthage references for external dependencies on GitLab (Closed)

Created:
March 15, 2018, 1:29 p.m. by a.shephard

Modified:
March 26, 2018, 10:28 a.m.

Reviewers:
d108, dean

Visibility:
Public.

Description

Issue 6486 - Update Carthage references for external dependencies on GitLab Favicon and YAJL-dynamic are now hosted on Gitlab. This ticket changes the references within the Cartfile to point towards the Gitlab repositories for these dependencies.

Patch Set 1 #

Total comments: 1

Patch Set 2 : Issue 6486 - Update Carthage refs for external dependencies on GL #

Created: March 19, 2018, 8:28 a.m.

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+4 lines, -4 lines)			Patch
	M	Cartfile	View	1	1 chunk	+2 lines, -2 lines	0 comments	Download
	M	Cartfile.resolved	View	1	1 chunk	+2 lines, -2 lines	0 comments	Download

Messages

Total messages: 7

Expand All Messages | Collapse All Messages

d108

On 2018/03/15 13:31:45, a.shephard wrote: While I support the use of Gitlab, I'd like to ...

March 15, 2018, 10:51 p.m. (2018-03-15 22:51:45 UTC) #2

dean

https://codereview.adblockplus.org/29723596/diff/29723597/Cartfile File Cartfile (right): https://codereview.adblockplus.org/29723596/diff/29723597/Cartfile#newcode1 Cartfile:1: git "https://gitlab.com/eyeo/adblockplus/FavIcon.git" ~> 2.0 Maybe a silly question - ...

March 16, 2018, 9:01 a.m. (2018-03-16 09:01:31 UTC) #3

d108

On 2018/03/16 09:01:31, dean wrote: > https://codereview.adblockplus.org/29723596/diff/29723597/Cartfile > File Cartfile (right): > > https://codereview.adblockplus.org/29723596/diff/29723597/Cartfile#newcode1 > ...

March 17, 2018, 1:50 a.m. (2018-03-17 01:50:46 UTC) #4

a.shephard

Sorry guys, just seen that. Edited it. Was a straight copy from GitLab so it ...

March 19, 2018, 8:29 a.m. (2018-03-19 08:29:52 UTC) #5

dean

On 2018/03/19 08:29:52, a.shephard wrote: > Sorry guys, just seen that. Edited it. Was a ...

March 19, 2018, 12:15 p.m. (2018-03-19 12:15:49 UTC) #6

d108

March 20, 2018, 2:39 a.m. (2018-03-20 02:39:26 UTC) #7

On 2018/03/19 12:15:49, dean wrote:
> On 2018/03/19 08:29:52, a.shephard wrote:
> > Sorry guys, just seen that. Edited it. Was a straight copy from GitLab so it
> > contained the .git suffix
> 
> LGTM

LGTM too

Expand All Messages | Collapse All Messages