Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code

Issue 29723596: Issue 6486 - Update Carthage references for external dependencies on GitLab (Closed)

Created:
March 15, 2018, 1:29 p.m. by a.shephard
Modified:
March 26, 2018, 10:28 a.m.
Reviewers:
d108, dean
Visibility:
Public.

Description

Issue 6486 - Update Carthage references for external dependencies on GitLab Favicon and YAJL-dynamic are now hosted on Gitlab. This ticket changes the references within the Cartfile to point towards the Gitlab repositories for these dependencies.

Patch Set 1 #

Total comments: 1

Patch Set 2 : Issue 6486 - Update Carthage refs for external dependencies on GL #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -4 lines) Patch
M Cartfile View 1 1 chunk +2 lines, -2 lines 0 comments Download
M Cartfile.resolved View 1 1 chunk +2 lines, -2 lines 0 comments Download

Messages

Total messages: 7
a.shephard
March 15, 2018, 1:31 p.m. (2018-03-15 13:31:45 UTC) #1
d108
On 2018/03/15 13:31:45, a.shephard wrote: While I support the use of Gitlab, I'd like to ...
March 15, 2018, 10:51 p.m. (2018-03-15 22:51:45 UTC) #2
dean
https://codereview.adblockplus.org/29723596/diff/29723597/Cartfile File Cartfile (right): https://codereview.adblockplus.org/29723596/diff/29723597/Cartfile#newcode1 Cartfile:1: git "https://gitlab.com/eyeo/adblockplus/FavIcon.git" ~> 2.0 Maybe a silly question - ...
March 16, 2018, 9:01 a.m. (2018-03-16 09:01:31 UTC) #3
d108
On 2018/03/16 09:01:31, dean wrote: > https://codereview.adblockplus.org/29723596/diff/29723597/Cartfile > File Cartfile (right): > > https://codereview.adblockplus.org/29723596/diff/29723597/Cartfile#newcode1 > ...
March 17, 2018, 1:50 a.m. (2018-03-17 01:50:46 UTC) #4
a.shephard
Sorry guys, just seen that. Edited it. Was a straight copy from GitLab so it ...
March 19, 2018, 8:29 a.m. (2018-03-19 08:29:52 UTC) #5
dean
On 2018/03/19 08:29:52, a.shephard wrote: > Sorry guys, just seen that. Edited it. Was a ...
March 19, 2018, 12:15 p.m. (2018-03-19 12:15:49 UTC) #6
d108
March 20, 2018, 2:39 a.m. (2018-03-20 02:39:26 UTC) #7
On 2018/03/19 12:15:49, dean wrote:
> On 2018/03/19 08:29:52, a.shephard wrote:
> > Sorry guys, just seen that. Edited it. Was a straight copy from GitLab so it
> > contained the .git suffix
> 
> LGTM

LGTM too

Powered by Google App Engine
This is Rietveld