Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code

Issue 29724599: Issue 6491 - Require Windows build 16299 for Adblock Plus for Microsoft Edge (Closed)

Created:
March 16, 2018, 10:47 p.m. by Sebastian Noack
Modified:
March 19, 2018, 5:42 p.m.
Reviewers:
kzar, Oleksandr
CC:
a.giammarchi
Visibility:
Public.

Description

Issue 6491 - Require Windows build 16299 for Adblock Plus for Microsoft Edge

Patch Set 1 #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -3 lines) Patch
M metadata.edge View 1 chunk +3 lines, -3 lines 1 comment Download

Messages

Total messages: 4
Sebastian Noack
March 16, 2018, 10:48 p.m. (2018-03-16 22:48:58 UTC) #1
Sebastian Noack
https://codereview.adblockplus.org/29724599/diff/29724600/metadata.edge File metadata.edge (right): https://codereview.adblockplus.org/29724599/diff/29724600/metadata.edge#newcode20 metadata.edge:20: logo_150.png = icons/abp-150.png The change here is because of ...
March 16, 2018, 10:50 p.m. (2018-03-16 22:50:14 UTC) #2
kzar
Assuming Ollie thinks this change is OK then this LGTM.
March 19, 2018, 3:16 p.m. (2018-03-19 15:16:01 UTC) #3
Oleksandr
March 19, 2018, 4:41 p.m. (2018-03-19 16:41:58 UTC) #4
Yes, LGTM.

Powered by Google App Engine
This is Rietveld