Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code
Issues
All Issues

Issue 29727633: Issue 6502 - Add Chinese build variant (Closed)

Created:
March 19, 2018, 11:28 p.m. by diegocarloslima
Modified:
March 28, 2018, 12:40 a.m.
Reviewers:
anton, jens
CC:
René Jeschke
Visibility:
Public.

Description

Issue 6502 - Add Chinese build variant

Patch Set 1 #

Total comments: 2

Patch Set 2 : Reverting changes in package name due to an error #

Unified diffs Side-by-side diffs Delta from patch set Stats (+21 lines, -4 lines) Patch
M adblockplussbrowser/AndroidManifest.xml View 1 1 chunk +1 line, -1 line 0 comments Download
M adblockplussbrowser/build.gradle View 2 chunks +20 lines, -3 lines 0 comments Download

Messages

Total messages: 5
diegocarloslima
March 19, 2018, 11:37 p.m. (2018-03-19 23:37:59 UTC) #1
diegocarloslima
https://codereview.adblockplus.org/29727633/diff/29727634/adblockplussbrowser/AndroidManifest.xml File adblockplussbrowser/AndroidManifest.xml (right): https://codereview.adblockplus.org/29727633/diff/29727634/adblockplussbrowser/AndroidManifest.xml#newcode3 adblockplussbrowser/AndroidManifest.xml:3: package="${applicationId}" This is just to keep consistency. We shall ...
March 19, 2018, 11:39 p.m. (2018-03-19 23:39:49 UTC) #2
anton
On 2018/03/19 23:39:49, diegocarloslima wrote: > https://codereview.adblockplus.org/29727633/diff/29727634/adblockplussbrowser/AndroidManifest.xml > File adblockplussbrowser/AndroidManifest.xml (right): > > https://codereview.adblockplus.org/29727633/diff/29727634/adblockplussbrowser/AndroidManifest.xml#newcode3 > ...
March 20, 2018, 6:06 a.m. (2018-03-20 06:06:56 UTC) #3
diegocarloslima
https://codereview.adblockplus.org/29727633/diff/29727634/adblockplussbrowser/AndroidManifest.xml File adblockplussbrowser/AndroidManifest.xml (right): https://codereview.adblockplus.org/29727633/diff/29727634/adblockplussbrowser/AndroidManifest.xml#newcode3 adblockplussbrowser/AndroidManifest.xml:3: package="${applicationId}" On 2018/03/19 23:39:49, diegocarloslima wrote: > This is ...
March 20, 2018, 12:12 p.m. (2018-03-20 12:12:18 UTC) #4
jens
March 27, 2018, 9:44 a.m. (2018-03-27 09:44:58 UTC) #5 
On 2018/03/20 12:12:18, diegocarloslima wrote:
>
https://codereview.adblockplus.org/29727633/diff/29727634/adblockplussbrowser...
> File adblockplussbrowser/AndroidManifest.xml (right):
> 
>
https://codereview.adblockplus.org/29727633/diff/29727634/adblockplussbrowser...
> adblockplussbrowser/AndroidManifest.xml:3: package="${applicationId}"
> On 2018/03/19 23:39:49, diegocarloslima wrote:
> > This is just to keep consistency. We shall remove those redundant fields in
> > manifest in a follow up issue
> 
> That change would produce a 'Cannot read packageName' error while performing
> Gradle sync, so I had to revert it. I will create a follow up issue to remove
> unused stuff for Gradle builds

LGTM

Powered by Google App Engine
This is Rietveld