Issue 29728661: Noissue - Update dependencies and tools

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 29728661: Noissue - Update dependencies and tools (Closed)

Created:
March 20, 2018, 6:29 p.m. by diegocarloslima

Modified:
April 20, 2018, 11:26 a.m.

Reviewers:
anton, jens

CC:
René Jeschke

Visibility:
Public.

Description

Noissue - Update dependencies and tools

Patch Set 1 #

Patch Set 2 : Update Kotlin version #

Created: March 28, 2018, 12:54 a.m.

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+8 lines, -11 lines)			Patch
	M	adblockplussbrowser/build.gradle	View	1	2 chunks	+4 lines, -3 lines	0 comments	Download
	M	build.gradle	View	1	3 chunks	+4 lines, -8 lines	0 comments	Download

Messages

Total messages: 4

Expand All Messages | Collapse All Messages

anton

On 2018/03/20 18:30:42, diegocarloslima wrote: LGTM. I did not know you're using Kotlin in production

March 21, 2018, 10:57 a.m. (2018-03-21 10:57:22 UTC) #2

jens

On 2018/03/21 10:57:22, anton wrote: > On 2018/03/20 18:30:42, diegocarloslima wrote: > > LGTM. > ...

March 27, 2018, 9:21 a.m. (2018-03-27 09:21:50 UTC) #3

jens

April 17, 2018, 1:39 p.m. (2018-04-17 13:39:17 UTC) #4

On 2018/03/27 09:21:50, jens wrote:
> On 2018/03/21 10:57:22, anton wrote:
> > On 2018/03/20 18:30:42, diegocarloslima wrote:
> > 
> > LGTM.
> > 
> > I did not know you're using Kotlin in production
> 
> There was a release of Kotlin version 1.2.31 in the meantime. Maybe we want to
> upgrade to that version?
> I did not add kotlin-android-extensions to the gradle file because we only use
> Kotlin for JUnit tests so far and we can't make use of synthetic properties in
> these tests. But if we enable the experimental mode for
kotlin-android-extension
> we could potentially make use of some other interesting features:
> https://kotlinlang.org/docs/tutorials/android-plugin.html

LGTM

Expand All Messages | Collapse All Messages