Issue 29730652: Issue 4580 - Stop using ext.onMessage in background page

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 29730652: Issue 4580 - Stop using ext.onMessage in background page

Created:
March 22, 2018, 7:53 p.m. by Manish Jethani

Modified:
March 22, 2018, 7:56 p.m.

Reviewers:
Sebastian Noack

CC:
kzar

Base URL:
https://hg.adblockplus.org/adblockpluschrome/

Visibility:
Public.

Description

Issue 4580 - Stop using ext.onMessage in background page

Patch Set 1 #

Total comments: 3

Created: March 22, 2018, 7:53 p.m.

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+52 lines, -72 lines)			Patch
	M	ext/background.js	View		5 chunks	+33 lines, -45 lines	1 comment	Download
	M	lib/messaging.js	View		2 chunks	+19 lines, -27 lines	2 comments	Download

Messages

Total messages: 2

Expand All Messages | Collapse All Messages

Manish Jethani

March 22, 2018, 7:56 p.m. (2018-03-22 19:56:55 UTC) #2

Patch Set 1

Note: once this is done, I'll make changes for the content script (which is more
work) and elsewhere.

https://codereview.adblockplus.org/29730652/diff/29730653/ext/background.js
File ext/background.js (right):

https://codereview.adblockplus.org/29730652/diff/29730653/ext/background.js#n...
ext/background.js:512: let Frame = ext.Frame = function(tabId, frameId, url)
So there's a Frame object now and it's used consistently everywhere.

https://codereview.adblockplus.org/29730652/diff/29730653/lib/messaging.js
File lib/messaging.js (right):

https://codereview.adblockplus.org/29730652/diff/29730653/lib/messaging.js#ne...
lib/messaging.js:39: // Add "page" and "frame" if the message was sent by a
content script.
This used to be in ext/background.js

https://codereview.adblockplus.org/29730652/diff/29730653/lib/messaging.js#ne...
lib/messaging.js:49: // The message sender receives only the first response.
Note: using Promise.race here to resolve with first resolved value, which is
equivalent to what was happening earlier, but we could also just use Promise.all
and return all resolved values (but this will require more changes elsewhere and
also the response might take longer).

Expand All Messages | Collapse All Messages