Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(773)

Issue 29733599: Issue 6523 - Update softlink for downloaded builds (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
2 years, 2 months ago by tlucas
Modified:
2 years, 2 months ago
CC:
kzar
Base URL:
https://hg.adblockplus.org/abpssembly/file/f92468d41835
Visibility:
Public.

Description

Issue 6523 - Update softlink for downloaded builds

Patch Set 1 #

Total comments: 1

Patch Set 2 : #

Patch Set 3 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+29 lines, -19 lines) Patch
M sitescripts/extensions/bin/createNightlies.py View 1 2 3 chunks +29 lines, -19 lines 0 comments Download

Messages

Total messages: 9
tlucas
Patch Set 1 * Insert missing logic for updating the softlink
2 years, 2 months ago (2018-03-26 09:37:18 UTC) #1
Sebastian Noack
LGTM
2 years, 2 months ago (2018-03-26 16:39:25 UTC) #2
Vasily Kuznetsov
Hi Tristan, Looks good but the way you store the path in `self.path` (and then ...
2 years, 2 months ago (2018-03-26 19:12:12 UTC) #3
tlucas
On 2018/03/26 19:12:12, Vasily Kuznetsov wrote: > Hi Tristan, > > Looks good but the ...
2 years, 2 months ago (2018-03-27 07:54:59 UTC) #4
Vasily Kuznetsov
On 2018/03/27 07:54:59, tlucas wrote: > On 2018/03/26 19:12:12, Vasily Kuznetsov wrote: > > Hi ...
2 years, 2 months ago (2018-03-27 08:49:59 UTC) #5
tlucas
Patch Set 2 * "Fail" gracefully when no download happened On 2018/03/27 08:49:59, Vasily Kuznetsov ...
2 years, 2 months ago (2018-03-27 10:13:50 UTC) #6
tlucas
Patch Set 3 * Ensure existence of the attribute "self.path"
2 years, 2 months ago (2018-03-27 10:28:12 UTC) #7
Vasily Kuznetsov
On 2018/03/27 10:28:12, tlucas wrote: > Patch Set 3 > > * Ensure existence of ...
2 years, 2 months ago (2018-03-27 10:29:38 UTC) #8
Sebastian Noack
2 years, 2 months ago (2018-03-27 18:27:13 UTC) #9
Message was sent while issue was closed.
LGTM
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld 87257f5