Issue 29735577: ABB: Noissue - Removed unused CI variables from Build Settings on ABB

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 29735577: ABB: Noissue - Removed unused CI variables from Build Settings on ABB (Closed)

Created:
March 28, 2018, 3:13 p.m. by a.shephard

Modified:
April 3, 2018, 11:25 a.m.

Reviewers:
d108, dean

Visibility:
Public.

Description

ABB: Noissue - Removed unused CI variables from Build Settings on ABB

Patch Set 1 #

Created: March 28, 2018, 3:13 p.m.

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+0 lines, -6 lines)			Patch
	M	AdblockBrowser.xcodeproj/project.pbxproj	View		3 chunks	+0 lines, -6 lines	0 comments	Download

Messages

Total messages: 3

Expand All Messages | Collapse All Messages

a.shephard

There were a couple of CI values still left over from the last commit I ...

March 28, 2018, 3:16 p.m. (2018-03-28 15:16:22 UTC) #1

d108

On 2018/03/28 15:16:22, a.shephard wrote: > There were a couple of CI values still left ...

March 29, 2018, 2:21 a.m. (2018-03-29 02:21:33 UTC) #2

dean

March 30, 2018, 12:12 a.m. (2018-03-30 00:12:24 UTC) #3

On 2018/03/29 02:21:33, d108 wrote:
> On 2018/03/28 15:16:22, a.shephard wrote:
> > There were a couple of CI values still left over from the last commit I did
on
> > ABB. Just raised it as a Noissue since the values weren't being used anyway.
> > More of a code cleanup if anything.
> > 
> > If you think it should be a separate issue, let me know and I'll raise one.
> 
> LGTM

I’d say it’s ok without an issue - LGTM

Expand All Messages | Collapse All Messages