Issue 29735580: Fixes #25 - Added page about upgrading adblock plus for firefox from < 2.8 to >= 3 (Closed)
|
Created:
March 28, 2018, 9:34 p.m. by juliandoucette Modified:
April 3, 2018, 11:39 a.m. Reviewers:
ire Base URL:
https://hg.adblockplus.org/web.adblockplus.org Visibility:
Public. |
DescriptionFixes #25 - Added page about upgrading adblock plus for firefox from < 2.8 to >= 3
Patch Set 1 #
Total comments: 6
Patch Set 2 : Iterated string numbers and renamed page #MessagesTotal messages: 6
Detail: I'd like to prioritize this issue above everything except for the help centre content update because I think that we should have responded to this issue much faster given the issue background.
Thanks Julian! Just a couple comments https://codereview.adblockplus.org/29735580/diff/29735581/pages/upgrade-adblo... File pages/upgrade-adblock-plus-for-firefox-from-2-8-to-3.md (right): https://codereview.adblockplus.org/29735580/diff/29735581/pages/upgrade-adblo... pages/upgrade-adblock-plus-for-firefox-from-2-8-to-3.md:1: title=Upgrading Adblock Plus from version 2.8.2 (or below) for Firefox (Not sure where else to put this) NIT/Suggest: Use a shorter/simpler page url e.g. just upgrading-abp-for-firefox https://codereview.adblockplus.org/29735580/diff/29735581/pages/upgrade-adblo... pages/upgrade-adblock-plus-for-firefox-from-2-8-to-3.md:4: {{ background-0 Beginning with Firefox 57, Mozilla changed the way that settings are stored in extensions (check out this [blog article](https://adblockplus.org/blog/the-plan-towards-offering-adblock-plus-for-firefox-as-a-web-extension) for more information). Because of this, Adblock Plus had to migrate its settings from one format to another between versions 2.8.2 and 3.0.0. }} 1. I think we start counting from 1 not 0? 2. No context?
(Were both of your comments NIT? e.g. LGTM + NITs?) Anyway, new patchset up. https://codereview.adblockplus.org/29735580/diff/29735581/pages/upgrade-adblo... File pages/upgrade-adblock-plus-for-firefox-from-2-8-to-3.md (right): https://codereview.adblockplus.org/29735580/diff/29735581/pages/upgrade-adblo... pages/upgrade-adblock-plus-for-firefox-from-2-8-to-3.md:1: title=Upgrading Adblock Plus from version 2.8.2 (or below) for Firefox On 2018/03/29 13:30:24, ire wrote: > (Not sure where else to put this) > > NIT/Suggest: Use a shorter/simpler page url e.g. just upgrading-abp-for-firefox I also had this dilemma... I chose a longer and more detailed name in order to make it more about upgrading from one version of our extension for firefox to another and less about upgrading our extension for firefox in general. I don't really know if this will make a difference :/ https://codereview.adblockplus.org/29735580/diff/29735581/pages/upgrade-adblo... pages/upgrade-adblock-plus-for-firefox-from-2-8-to-3.md:4: {{ background-0 Beginning with Firefox 57, Mozilla changed the way that settings are stored in extensions (check out this [blog article](https://adblockplus.org/blog/the-plan-towards-offering-adblock-plus-for-firefox-as-a-web-extension) for more information). Because of this, Adblock Plus had to migrate its settings from one format to another between versions 2.8.2 and 3.0.0. }} On 2018/03/29 13:30:23, ire wrote: > 1. I think we start counting from 1 not 0? > 2. No context? 1. Programmers start at 0 :| ... (I'm kidding, you're right.) 2. I don't think context is necessary for "normal" (paragraph) context
LGTM https://codereview.adblockplus.org/29735580/diff/29735581/pages/upgrade-adblo... File pages/upgrade-adblock-plus-for-firefox-from-2-8-to-3.md (right): https://codereview.adblockplus.org/29735580/diff/29735581/pages/upgrade-adblo... pages/upgrade-adblock-plus-for-firefox-from-2-8-to-3.md:1: title=Upgrading Adblock Plus from version 2.8.2 (or below) for Firefox On 2018/03/29 22:23:56, juliandoucette wrote: > On 2018/03/29 13:30:24, ire wrote: > > (Not sure where else to put this) > > > > NIT/Suggest: Use a shorter/simpler page url e.g. just > upgrading-abp-for-firefox > > I also had this dilemma... I chose a longer and more detailed name in order to > make it more about upgrading from one version of our extension for firefox to > another and less about upgrading our extension for firefox in general. I don't > really know if this will make a difference :/ Yeah I'm not 100% sure which works better either. Let's leave it with your implementation then. https://codereview.adblockplus.org/29735580/diff/29735581/pages/upgrade-adblo... pages/upgrade-adblock-plus-for-firefox-from-2-8-to-3.md:4: {{ background-0 Beginning with Firefox 57, Mozilla changed the way that settings are stored in extensions (check out this [blog article](https://adblockplus.org/blog/the-plan-towards-offering-adblock-plus-for-firefox-as-a-web-extension) for more information). Because of this, Adblock Plus had to migrate its settings from one format to another between versions 2.8.2 and 3.0.0. }} On 2018/03/29 22:23:56, juliandoucette wrote: > On 2018/03/29 13:30:23, ire wrote: > > 1. I think we start counting from 1 not 0? > > 2. No context? > > 1. Programmers start at 0 :| ... (I'm kidding, you're right.) :p > 2. I don't think context is necessary for "normal" (paragraph) context Ack.
|
