Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(50)

Issue 29737558: Issue 6538 - Implement support for snippet filter option

Can't Edit
Can't Publish+Mail
Start Review
Created:
3 weeks, 4 days ago by Manish Jethani
Modified:
2 weeks ago
Reviewers:
sergei, kzar
CC:
mapx
Base URL:
https://hg.adblockplus.org/adblockpluscore/
Visibility:
Public.

Description

Issue 6538 - Implement support for snippet filter option

Patch Set 1 #

Patch Set 2 : Check for null and blank string instead #

Patch Set 3 : Rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+18 lines, -4 lines) Patch
M lib/filterClasses.js View 1 2 6 chunks +18 lines, -4 lines 0 comments Download

Messages

Total messages: 4
Manish Jethani
3 weeks, 4 days ago (2018-03-30 20:19:00 UTC) #1
kzar
(Adding Mapx to Cc at his request.)
3 weeks, 1 day ago (2018-04-03 08:59:47 UTC) #2
Manish Jethani
Patch Set 2: Check for null and blank string instead
3 weeks, 1 day ago (2018-04-03 10:46:30 UTC) #3
sergei
2 weeks ago (2018-04-11 09:57:18 UTC) #4
Could you please add tests?
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld 87257f5