Issue 6507 - Inject style sheet proactively from background page

Issue 6507 - Inject style sheet proactively from background page

[Manish Jethani, 2018-04-06 06:20:02]

Patch Set 1
Patch Set 2: Polish up
Patch Set 3: Add delay

https://codereview.adblockplus.org/29738592/diff/29744555/composer.postload.js
File composer.postload.js (right):

https://codereview.adblockplus.org/29738592/diff/29744555/composer.postload.j...
composer.postload.js:546: browser.runtime.sendMessage({type:
"elemhide.needApply"});
Here we just have to request the background page to run element hiding again.

https://codereview.adblockplus.org/29738592/diff/29744555/lib/cssInjection.js
File lib/cssInjection.js (right):

https://codereview.adblockplus.org/29738592/diff/29744555/lib/cssInjection.js...
lib/cssInjection.js:41: function delay(time, func = () => {}, ...args)
This simply wraps setTimeout into a promise, which is convenient to use
elsewhere (in a promise chain).

https://codereview.adblockplus.org/29738592/diff/29744555/lib/cssInjection.js...
lib/cssInjection.js:230: delay(250, browser.tabs.sendMessage, page.id, message,
{frameId: frame.id})
Unfortunately sometimes the content script hasn't loaded yet when this code runs
(rarely, but it happens). Most of the time on modern browsers the code won't
even come to this point, because everything is handled by the background page.
But when the DevTools panel is open, for example, we still need to contact the
content script. In that case, we can retry a couple of times with increasing
delays of 250ms and 1s.

[Manish Jethani, 2018-09-04 08:51:26]

Since after the changes for snippets we have got more knowledge and experience
about when to inject scripts (and now there's also the new contentScripts API on
Firefox), this is making less sense than it did initially.

Closed.