Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code

Issue 29741555: Fixes #2 - Update text on adblockplus.org/acceptable-ads (Closed)

Created:
April 3, 2018, 9:58 a.m. by ire
Modified:
April 3, 2018, 4:38 p.m.
Reviewers:
juliandoucette
Base URL:
https://hg.adblockplus.org/web.adblockplus.org
Visibility:
Public.

Description

Fixes #2 - Update text on adblockplus.org/acceptable-ads

Patch Set 1 #

Total comments: 2
Unified diffs Side-by-side diffs Delta from patch set Stats (+59 lines, -79 lines) Patch
M pages/acceptable-ads.md View 4 chunks +57 lines, -78 lines 0 comments Download
M templates/default.tmpl View 1 chunk +2 lines, -1 line 2 comments Download

Messages

Total messages: 5
ire
April 3, 2018, 9:58 a.m. (2018-04-03 09:58:20 UTC) #1
ire
Ready for review https://codereview.adblockplus.org/29741555/diff/29741556/templates/default.tmpl File templates/default.tmpl (right): https://codereview.adblockplus.org/29741555/diff/29741556/templates/default.tmpl#newcode40 templates/default.tmpl:40: {% set page_title = page_title or ...
April 3, 2018, 10 a.m. (2018-04-03 10:00:32 UTC) #2
juliandoucette
LGTM https://codereview.adblockplus.org/29741555/diff/29741556/templates/default.tmpl File templates/default.tmpl (right): https://codereview.adblockplus.org/29741555/diff/29741556/templates/default.tmpl#newcode40 templates/default.tmpl:40: {% set page_title = page_title or title %} ...
April 3, 2018, 1:07 p.m. (2018-04-03 13:07:51 UTC) #3
juliandoucette
Will you please request a post-QA review after pushing?
April 3, 2018, 1:09 p.m. (2018-04-03 13:09:03 UTC) #4
ire
April 3, 2018, 4:38 p.m. (2018-04-03 16:38:07 UTC) #5
On 2018/04/03 13:09:03, juliandoucette wrote:
> Will you please request a post-QA review after pushing?

Will do

Powered by Google App Engine
This is Rietveld