Noissue - Move horizontal-list class to website-defaults implementation

Noissue - Move horizontal-list class to website-defaults implementation

[ire, 2018-04-04 09:08:43]

Ready for review

[juliandoucette, 2018-04-04 09:44:56]

I'm getting an error when I update the dependencies :/

(The code looks good to me... But I must be able to test before approving.)

[ire, 2018-04-04 10:36:26]

On 2018/04/04 09:44:56, juliandoucette wrote:
> I'm getting an error when I update the dependencies :/
> 
> (The code looks good to me... But I must be able to test before approving.)

Do you mean literally update, i.e. `npm update` or just a regular `npm install`.


If so, the error could be handled separately and shouldn't affect the site until
we decide to update.

[juliandoucette, 2018-04-04 10:55:26]

On 2018/04/04 10:36:26, ire wrote:
> On 2018/04/04 09:44:56, juliandoucette wrote:
> > I'm getting an error when I update the dependencies :/
> > 
> > (The code looks good to me... But I must be able to test before approving.)
> 
> Do you mean literally update, i.e. `npm update` or just a regular `npm
install`.
> 
> 
> If so, the error could be handled separately and shouldn't affect the site
until
> we decide to update.

I mean npm install. Are you able to remove your node_modules directory and
perform a fresh install successfully?

[juliandoucette, 2018-04-04 14:28:04]

LGTM

(It worked now. I don't know if you changed anything or if it was an
hg.adblockplus.org issue. :/)

[ire, 2018-04-05 07:26:38]

On 2018/04/04 14:28:04, juliandoucette wrote:
> LGTM
> 
> (It worked now. I don't know if you changed anything or if it was an
> http://hg.adblockplus.org issue. :/)

Thanks! 

No idea what happened because I didn't change anything