Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(557)

Issue 29743618: Issue 6608 - Removed CI refs from Target settings for ABB and Share Extension (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
5 months, 2 weeks ago by a.shephard
Modified:
4 months, 4 weeks ago
Reviewers:
dean, d108
Visibility:
Public.

Description

Issue 6608 - Removed CI refs from Target settings for ABB and Share Extension

Patch Set 1 #

Total comments: 3

Patch Set 2 : Noissue - Removed CI refs from Target settings for ABB and Share ext #

Total comments: 2

Patch Set 3 : Noissue - Removed CI refs from ABB Target and Share Extension #

Patch Set 4 : Issue 6608 - Remove CI refs from ABB. Added BUILD_NUMBER and made issue number also. #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+54 lines, -51 lines) Patch
M AdBlockBrowser/Info.plist View 1 2 6 chunks +12 lines, -12 lines 0 comments Download
M AdblockBrowser.xcodeproj/project.pbxproj View 1 2 3 4 chunks +4 lines, -1 line 1 comment Download
M ExtensionShare/Info.plist View 1 2 1 chunk +38 lines, -38 lines 0 comments Download

Messages

Total messages: 13
a.shephard
5 months, 2 weeks ago (2018-04-05 11:49:06 UTC) #1
dean
https://codereview.adblockplus.org/29743618/diff/29743619/AdBlockBrowser/Info.plist File AdBlockBrowser/Info.plist (right): https://codereview.adblockplus.org/29743618/diff/29743619/AdBlockBrowser/Info.plist#newcode54 AdBlockBrowser/Info.plist:54: <string>05_04_2018</string> Same as the other file, I'd suggest having ...
5 months, 2 weeks ago (2018-04-06 00:03:56 UTC) #2
a.shephard
Updated to Patchset 2. I've changed it so that both values (CFBundleVersion & CFBundleShortVersion) are ...
5 months, 2 weeks ago (2018-04-06 09:58:20 UTC) #3
d108
https://codereview.adblockplus.org/29743618/diff/29744585/AdBlockBrowser/Info.plist File AdBlockBrowser/Info.plist (right): https://codereview.adblockplus.org/29743618/diff/29744585/AdBlockBrowser/Info.plist#newcode54 AdBlockBrowser/Info.plist:54: <string>2.0.0</string> I suggest reverting CFBundleVersion to be the build ...
5 months, 2 weeks ago (2018-04-06 23:23:59 UTC) #4
a.shephard
On 2018/04/06 23:23:59, d108 wrote: > https://codereview.adblockplus.org/29743618/diff/29744585/AdBlockBrowser/Info.plist > File AdBlockBrowser/Info.plist (right): > > https://codereview.adblockplus.org/29743618/diff/29744585/AdBlockBrowser/Info.plist#newcode54 > ...
5 months ago (2018-04-18 11:24:03 UTC) #5
d108
On 2018/04/18 11:24:03, a.shephard wrote: > On 2018/04/06 23:23:59, d108 wrote: > > > https://codereview.adblockplus.org/29743618/diff/29744585/AdBlockBrowser/Info.plist ...
5 months ago (2018-04-19 02:36:37 UTC) #6
a.shephard
Put it to BUILD_NUMBER for now until we move to GitLab and work with CI.
5 months ago (2018-04-19 09:11:08 UTC) #7
dean
On 2018/04/19 09:11:08, a.shephard wrote: > Put it to BUILD_NUMBER for now until we move ...
5 months ago (2018-04-20 00:25:56 UTC) #8
d108
On 2018/04/19 09:11:08, a.shephard wrote: > Put it to BUILD_NUMBER for now until we move ...
5 months ago (2018-04-21 04:07:28 UTC) #9
a.shephard
Added BUILD_NUMBER property to the Build Settings and created an issue number. Will probably just ...
4 months, 4 weeks ago (2018-04-23 08:38:07 UTC) #10
d108
On 2018/04/23 08:38:07, a.shephard wrote: > Added BUILD_NUMBER property to the Build Settings and created ...
4 months, 4 weeks ago (2018-04-23 22:00:17 UTC) #11
dean
On 2018/04/23 22:00:17, d108 wrote: > On 2018/04/23 08:38:07, a.shephard wrote: > > Added BUILD_NUMBER ...
4 months, 4 weeks ago (2018-04-23 22:41:49 UTC) #12
dean
4 months, 4 weeks ago (2018-04-23 22:42:13 UTC) #13
with exception to the change in the SwiftLint script - LGTM.

https://codereview.adblockplus.org/29743618/diff/29759576/AdblockBrowser.xcod...
File AdblockBrowser.xcodeproj/project.pbxproj (right):

https://codereview.adblockplus.org/29743618/diff/29759576/AdblockBrowser.xcod...
AdblockBrowser.xcodeproj/project.pbxproj:1239: shellScript =
"exit\nSWIFTLINT=\"/usr/local/bin/swiftlint\"\nif [ -f $SWIFTLINT ]\nthen\n   
$SWIFTLINT\nelse\n    echo \"warning: SwiftLint not installed, download from
https://github.com/realm/SwiftLint\"\nfi";
I think this change needs to be rolled back and may be committed in error.
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld 87257f5