Issue 29744582: Fixes #12 - Add a favicon

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 29744582: Fixes #12 - Add a favicon (Closed)

Created:
April 6, 2018, 9:14 a.m. by ire

Modified:
April 6, 2018, 1:23 p.m.

Reviewers:
juliandoucette

Base URL:
https://hg.adblockplus.org/help.eyeo.com

Visibility:
Public.

Description

Fixes #12 - Add a favicon Issue - https://gitlab.com/eyeo/websites/help.eyeo.com/issues/12

Patch Set 1 #

Created: April 6, 2018, 9:14 a.m.

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+0 lines, -0 lines)			Patch
	A	static/favicon.ico	View		Binary file		0 comments	Download

Messages

Total messages: 5

Expand All Messages | Collapse All Messages

ire

I kept this to just the favicon and not any other icons mainly for simplicity ...

April 6, 2018, 9:16 a.m. (2018-04-06 09:16:16 UTC) #2

juliandoucette

On 2018/04/06 09:16:16, ire wrote: > I kept this to just the favicon and not ...

April 6, 2018, 11:57 a.m. (2018-04-06 11:57:08 UTC) #3

ire

April 6, 2018, 1:22 p.m. (2018-04-06 13:22:42 UTC) #5

Thanks!

On 2018/04/06 11:57:08, juliandoucette wrote:
> On 2018/04/06 09:16:16, ire wrote:
> > I kept this to just the favicon and not any other icons mainly for
simplicity
> > and to get this out sooner since we don't already have the different icon
> sizes
> > we would want/need.
> 
> Ack. Shouldn't it be the eyeo logo though? ABP is only one product on the help
> centre. And we explicitly decided to brand the website as eyeo and not ABP
> (against my recommendation).

See the discussion in the Issue

Expand All Messages | Collapse All Messages