Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code

Side by Side Diff: lib/filterNotifier.js

Issue 29746555: Issue 6564 - Replace desc and extend with __proto__ (Closed) Base URL: https://hg.adblockplus.org/adblockpluscore/
Patch Set: Created April 8, 2018, 8:57 a.m.
Left:
Right:
Use n/p to move between diff chunks; N/P to move between comments.
Jump to:
View unified diff | Download patch
« no previous file with comments | « lib/filterClasses.js ('k') | lib/subscriptionClasses.js » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 /* 1 /*
2 * This file is part of Adblock Plus <https://adblockplus.org/>, 2 * This file is part of Adblock Plus <https://adblockplus.org/>,
3 * Copyright (C) 2006-present eyeo GmbH 3 * Copyright (C) 2006-present eyeo GmbH
4 * 4 *
5 * Adblock Plus is free software: you can redistribute it and/or modify 5 * Adblock Plus is free software: you can redistribute it and/or modify
6 * it under the terms of the GNU General Public License version 3 as 6 * it under the terms of the GNU General Public License version 3 as
7 * published by the Free Software Foundation. 7 * published by the Free Software Foundation.
8 * 8 *
9 * Adblock Plus is distributed in the hope that it will be useful, 9 * Adblock Plus is distributed in the hope that it will be useful,
10 * but WITHOUT ANY WARRANTY; without even the implied warranty of 10 * but WITHOUT ANY WARRANTY; without even the implied warranty of
11 * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the 11 * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
12 * GNU General Public License for more details. 12 * GNU General Public License for more details.
13 * 13 *
14 * You should have received a copy of the GNU General Public License 14 * You should have received a copy of the GNU General Public License
15 * along with Adblock Plus. If not, see <http://www.gnu.org/licenses/>. 15 * along with Adblock Plus. If not, see <http://www.gnu.org/licenses/>.
16 */ 16 */
17 17
18 "use strict"; 18 "use strict";
19 19
20 /** 20 /**
21 * @fileOverview This component manages listeners and calls them to distributes 21 * @fileOverview This component manages listeners and calls them to distributes
22 * messages about filter changes. 22 * messages about filter changes.
23 */ 23 */
24 24
25 const {EventEmitter} = require("./events"); 25 const {EventEmitter} = require("./events");
26 const {desc} = require("./coreUtils");
27 26
28 const CATCH_ALL = "__all"; 27 const CATCH_ALL = "__all";
29 28
30 /** 29 /**
31 * @callback FilterNotifierCatchAllListener 30 * @callback FilterNotifierCatchAllListener
32 * @param {string} action 31 * @param {string} action
33 * @param {Subscription|Filter} item 32 * @param {Subscription|Filter} item
34 * @param {...*} additionalInfo 33 * @param {...*} additionalInfo
35 */ 34 */
36 35
37 /** 36 /**
38 * This class allows registering and triggering listeners for filter events. 37 * This class allows registering and triggering listeners for filter events.
39 * @class 38 * @class
40 */ 39 */
41 exports.FilterNotifier = Object.create(new EventEmitter(), desc({ 40 exports.FilterNotifier = {
41 __proto__: new EventEmitter(),
42
42 /** 43 /**
43 * Adds a listener 44 * Adds a listener
44 * 45 *
45 * @deprecated use FilterNotifier.on(action, callback) 46 * @deprecated use FilterNotifier.on(action, callback)
46 * @param {FilterNotifierCatchAllListener} listener 47 * @param {FilterNotifierCatchAllListener} listener
47 */ 48 */
48 addListener(listener) 49 addListener(listener)
49 { 50 {
50 let listeners = this._listeners.get(CATCH_ALL); 51 let listeners = this._listeners.get(CATCH_ALL);
51 if (!listeners || listeners.indexOf(listener) == -1) 52 if (!listeners || listeners.indexOf(listener) == -1)
(...skipping 24 matching lines...) Expand all
76 * @param {*} param1 77 * @param {*} param1
77 * @param {*} param2 78 * @param {*} param2
78 * @param {*} param3 79 * @param {*} param3
79 * @deprecated use FilterNotifier.emit(action) 80 * @deprecated use FilterNotifier.emit(action)
80 */ 81 */
81 triggerListeners(action, item, param1, param2, param3) 82 triggerListeners(action, item, param1, param2, param3)
82 { 83 {
83 this.emit(action, item, param1, param2, param3); 84 this.emit(action, item, param1, param2, param3);
84 this.emit(CATCH_ALL, action, item, param1, param2, param3); 85 this.emit(CATCH_ALL, action, item, param1, param2, param3);
85 } 86 }
86 })); 87 };
OLDNEW
« no previous file with comments | « lib/filterClasses.js ('k') | lib/subscriptionClasses.js » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld