Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code

Issue 29746555: Issue 6564 - Replace desc and extend with __proto__ (Closed)

Created:
April 8, 2018, 8:57 a.m. by Manish Jethani
Modified:
June 12, 2018, 2:50 a.m.
Reviewers:
kzar
CC:
sergei
Base URL:
https://hg.adblockplus.org/adblockpluscore/
Visibility:
Public.

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+59 lines, -53 lines) Patch
M lib/coreUtils.js View 1 chunk +0 lines, -18 lines 0 comments Download
M lib/filterClasses.js View 11 chunks +36 lines, -21 lines 0 comments Download
M lib/filterNotifier.js View 2 chunks +4 lines, -3 lines 0 comments Download
M lib/subscriptionClasses.js View 6 chunks +19 lines, -11 lines 0 comments Download

Messages

Total messages: 5
Manish Jethani
April 8, 2018, 8:57 a.m. (2018-04-08 08:57:42 UTC) #1
Manish Jethani
Patch Set 1
April 8, 2018, 9 a.m. (2018-04-08 09:00:20 UTC) #2
sergei
Why not to switch to `class`es? It seems they are supported by all platforms.
April 9, 2018, 8:06 a.m. (2018-04-09 08:06:28 UTC) #3
Manish Jethani
On 2018/04/09 08:06:28, sergei wrote: > Why not to switch to `class`es? It seems they ...
April 11, 2018, 11:30 a.m. (2018-04-11 11:30:24 UTC) #4
Manish Jethani
June 12, 2018, 2:50 a.m. (2018-06-12 02:50:52 UTC) #5
Message was sent while issue was closed.
On 2018/04/11 11:30:24, Manish Jethani wrote:
> On 2018/04/09 08:06:28, sergei wrote:
> > Why not to switch to `class`es? It seems they are supported by all
platforms.
> 
> Closing this as we agreed to use classes.

https://codereview.adblockplus.org/29803559/

Powered by Google App Engine
This is Rietveld