Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code

Issue 29747568: Fixes #11 - Heading size and space is hard to differentiate (Closed)

Created:
April 9, 2018, 9:42 a.m. by ire
Modified:
April 9, 2018, 2:36 p.m.
Reviewers:
juliandoucette
Base URL:
https://hg.adblockplus.org/help.eyeo.com
Visibility:
Public.

Description

Fixes #11 - Heading size and space is hard to differentiate

Patch Set 1 #

Total comments: 1

Patch Set 2 : Make change in website-defaults #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -1 line) Patch
M static/scss/_content.scss View 1 1 chunk +2 lines, -1 line 0 comments Download

Messages

Total messages: 4
ire
April 9, 2018, 9:42 a.m. (2018-04-09 09:42:56 UTC) #1
ire
It just occurred to me that this change could/should be in website-defaults instead? https://codereview.adblockplus.org/29747568/diff/29747569/static/src/scss/content/_typography.scss File ...
April 9, 2018, 9:44 a.m. (2018-04-09 09:44:08 UTC) #2
juliandoucette
LGTM - And I agree that we should address this in website-defaults instead.
April 9, 2018, 12:25 p.m. (2018-04-09 12:25:14 UTC) #3
ire
April 9, 2018, 2:31 p.m. (2018-04-09 14:31:09 UTC) #4
On 2018/04/09 12:25:14, juliandoucette wrote:
> LGTM - And I agree that we should address this in website-defaults instead.

Great, I will make this change there instead and push. Thanks.

Powered by Google App Engine
This is Rietveld