Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code

Delta Between Two Patch Sets: build-v8.gypi

Issue 29748587: Issue 6063, 6531 - Update V8 to 6.5.254.41, use C++14 and NDK-r16b (Closed) Base URL: https://github.com/adblockplus/libadblockplus@549616e865707b89e95659d55c70e22d63130ce5
Left Patch Set: Created April 10, 2018, 1:45 p.m.
Right Patch Set: fix and simplify build for Windows Created April 18, 2018, 6:41 p.m.
Left:
Right:
Use n/p to move between diff chunks; N/P to move between comments.
Jump to:
Left: Side by side diff | Download
Right: Side by side diff | Download
« no previous file with change/comment | « build-v8.cmd ('k') | common.gypi » ('j') | no next file with change/comment »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
LEFTRIGHT
1 { 1 {
2 'includes': ['common.gypi'], 2 'includes': ['common.gypi'],
3 'variables': { 3 'variables': {
4 'v8_enable_i18n_support': 0, 4 'v8_enable_i18n_support': 0,
5 'v8_optimized_debug': 0, 5 'v8_optimized_debug': 0,
6 'v8_use_external_startup_data': 0, 6 'v8_use_external_startup_data': 0,
7 'v8_use_snapshot': 1, 7 'v8_use_snapshot': 1,
8 'v8_random_seed%': 0, 8 'v8_random_seed%': 0,
9 'v8_android_log_stdout': 1, 9 'v8_android_log_stdout': 1,
10 }, 10 },
11 11
12 'target_defaults': { 12 'target_defaults': {
13 'defines': [ 13 'defines': [
14 '__ANDROID_API__=16', 14 '__ANDROID_API__=16',
15 ], 15 ],
16 }, 16 },
17 'conditions': [ 17 'conditions': [
18 ['OS=="linux" or OS=="mac"', {
19 'target_defaults': {
20 'cflags': [ '-fPIC' ],
21 'cflags_cc': [ '-fPIC' ]
22 }
23 }],
18 ['OS=="win"', { 24 ['OS=="win"', {
19 'target_defaults': { 25 'target_defaults': {
20 'configurations': { 26 'configurations': {
21 'Debug': { 27 'Debug': {
22 'conditions': [ 28 'conditions': [
23 ['target_arch=="x64"', { 29 ['target_arch=="x64"', {
24 'msvs_settings': { 30 'msvs_settings': {
25 'VCCLCompilerTool': { 31 'VCCLCompilerTool': {
26 'AdditionalOptions': [ 32 'AdditionalOptions': [
27 '/bigobj', # compiling fatal error C1128: number of sectio ns exceeded object file format limit: compile with /bigobj 33 '/bigobj', # compiling fatal error C1128: number of sectio ns exceeded object file format limit: compile with /bigobj
28 ] 34 ]
29 } 35 }
30 } 36 }
31 }] 37 }]
32 ], 38 ],
33 } 39 }
34 }, 40 },
35 'msvs_settings': { 41 'msvs_settings': {
36 'VCCLCompilerTool': { 42 'VCCLCompilerTool': {
37 'WarningLevel': 0, 43 'WarningLevel': 0,
38 }, 44 },
39 }, 45 },
40 } 46 }
41 }] 47 }]
42 ], 48 ],
43 } 49 }
LEFTRIGHT

Powered by Google App Engine
This is Rietveld