Issue 6063, 6531 - Update V8 to 6.5.254.41, use C++14 and NDK-r16b

[sergei, 2018-04-10 13:56:49]

I will update V8 binaries and CI after landing
https://codereview.adblockplus.org/29747555/ and receiving the confirmation from
the mobile team that the everything is working.

https://codereview.adblockplus.org/29748587/diff/29748588/Makefile
File Makefile (right):

https://codereview.adblockplus.org/29748587/diff/29748588/Makefile#newcode142
Makefile:142: LOCAL_LDFLAGS="-Wl,--allow-multiple-definition" \
These two parameters are required to link our executables for android.

Since it's only for our tests which do run on a mobile device, I would propose
to review all compilation and linking flags in the meson configuration for
libadblockplus.

https://codereview.adblockplus.org/29748587/diff/29748588/dependencies
File dependencies (right):

https://codereview.adblockplus.org/29748587/diff/29748588/dependencies#newcode6
dependencies:6: third_party/gyp = gyp hg:5382e1309be1
git:85707cef17503c05c0105fb0430fd8ada907d719
gyp should be updated in order to let us generate Visual Studio 2017 solutions.

Our changes are merged in the gyp repo
https://hg.adblockplus.org/gyp/rev/5382e1309be1
https://github.com/adblockplus/gyp/commit/85707cef17503c05c0105fb0430fd8ada90...

https://codereview.adblockplus.org/29748587/diff/29748588/dependencies#newcode7
dependencies:7: third_party/v8 = v8-googlesource hg:
git:https://github.com/abby-sergz/v8-googlesource.git@40e33a00e7b0e7856225e751386df9d2e9e743eb
This line will be updated after https://codereview.adblockplus.org/29747555/

[hub, 2018-04-11 01:57:41]

LGTM

https://codereview.adblockplus.org/29748587/diff/29748588/Makefile
File Makefile (right):

https://codereview.adblockplus.org/29748587/diff/29748588/Makefile#newcode142
Makefile:142: LOCAL_LDFLAGS="-Wl,--allow-multiple-definition" \
On 2018/04/10 13:56:48, sergei wrote:
> These two parameters are required to link our executables for android.
> 
> Since it's only for our tests which do run on a mobile device, I would propose
> to review all compilation and linking flags in the meson configuration for
> libadblockplus.

I'll be mindful when I rebase my patch

[hub, 2018-04-11 02:01:04]

in https://issues.adblockplus.org/ticket/6063#comment:16 you mention the gn
files need to be updated. Is it still the case ? 

(BTW you didn't add the review to the issue either)

[sergei, 2018-04-11 08:00:04]

On 2018/04/11 02:01:04, hub wrote:
> in https://issues.adblockplus.org/ticket/6063#comment:16 you mention the gn
> files need to be updated. Is it still the case ? 
Yes, they are not touched here because they are not used in libadblockplus so
far.

> 
> (BTW you didn't add the review to the issue either)

Done.

[sergei, 2018-04-18 16:00:18]

I hope it's the final version, if there are some CI issues I will let you know.

Could you please review the changes?

[hub, 2018-04-18 18:29:14]

LGTM

[sergei, 2018-04-18 18:44:54]

On 2018/04/18 18:29:14, hub wrote:
> LGTM

I have just submitted the patch set 4, sorry.

[sergei, 2018-04-18 18:48:26]

BTW, the CI for linux/android/osx passed, I had also prepared on the server
binaries of V8 for win32-debug and it passed too. So, I will finish with the
rest binaries of V8 for windows, run the CI JIC yet one time and land it. Of
course the latter is only after obtaining the approval here.

[hub, 2018-04-18 18:50:28]

LGTM