v8.gypi - Issue 29748587: Issue 6063, 6531 - Update V8 to 6.5.254.41, use C++14 and NDK-r16b

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Delta Between Two Patch Sets: v8.gypi

Issue 29748587: Issue 6063, 6531 - Update V8 to 6.5.254.41, use C++14 and NDK-r16b (Closed) Base URL: https://github.com/adblockplus/libadblockplus@549616e865707b89e95659d55c70e22d63130ce5

Left Patch Set: fix for android and set proper V8 commits Created April 18, 2018, 3:26 p.m.

Right Patch Set: fix and simplify build for Windows Created April 18, 2018, 6:41 p.m.

Left:
Right:

Use n/p to move between diff chunks; N/P to move between comments.

Jump to:

Right: Side by side diff | Download

LEFT	RIGHT
(no file at all)
1 {	1 {

2 'variables': {	2 'variables': {

3 'libv8_include_dir%': 'third_party/v8/include',	3 'libv8_include_dir%': 'third_party/v8/include',

4 'libv8_build_targets': [],	4 'libv8_build_targets': [],

5 'libv8_no_build%': 0,	5 'libv8_no_build%': 0,

6 'conditions': [[	6 'conditions': [[

7 'OS=="win"', {	7 'OS=="win"', {

8 'libv8_lib_dir%': 'v8/third_party/v8/src/<(CONFIGURATION_NAME)',	8 'libv8_lib_dir%': 'v8/third_party/v8/src/<(CONFIGURATION_NAME)',

9 'libv8_libs': [	9 'libv8_libs': [

10 '-lv8_libplatform',	10 '-lv8_libplatform',

(...skipping 48 matching lines...) Expand 10 before \| Expand all \| Expand 10 after Loading...
59 'build/<(target_arch)/v8/build/<(CONFIGURATION_NAME)/v8_libbase.lib' ,	59 'build/<(target_arch)/v8/build/<(CONFIGURATION_NAME)/v8_libbase.lib' ,

60 'build/<(target_arch)/v8/build/<(CONFIGURATION_NAME)/v8_libsampler.l ib',	60 'build/<(target_arch)/v8/build/<(CONFIGURATION_NAME)/v8_libsampler.l ib',

61 'build/<(target_arch)/v8/build/<(CONFIGURATION_NAME)/v8_snapshot.lib ',	61 'build/<(target_arch)/v8/build/<(CONFIGURATION_NAME)/v8_snapshot.lib ',

62 ],	62 ],

63 'action': [	63 'action': [

64 'cmd',	64 'cmd',

65 '/C',	65 '/C',

66 'build-v8.cmd',	66 'build-v8.cmd',

67 '$(MSBuildBinPath)',	67 '$(MSBuildBinPath)',

68 '<(target_arch)',	68 '<(target_arch)',

69 '<(CONFIGURATION_NAME)',	69 '<(CONFIGURATION_NAME)'

70 '$(PlatformToolset)'

71 ]	70 ]

72 }],	71 }],

73 }]	72 }]

74 }	73 }

75 ]],	74 ]],

76 }	75 }

LEFT	RIGHT