build-v8.cmd - Issue 29748587: Issue 6063, 6531 - Update V8 to 6.5.254.41, use C++14 and NDK-r16b

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Unified Diff: build-v8.cmd

Issue 29748587: Issue 6063, 6531 - Update V8 to 6.5.254.41, use C++14 and NDK-r16b (Closed) Base URL: https://github.com/adblockplus/libadblockplus@549616e865707b89e95659d55c70e22d63130ce5

Patch Set: fix and simplify build for Windows Created April 18, 2018, 6:41 p.m.

Use n/p to move between diff chunks; N/P to move between comments.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: build-v8.cmd

diff --git a/build-v8.cmd b/build-v8.cmd

index f14ebcac537b7d2fac46802679e5075459ba1e56..28a3686a851185b47865ecd4970bd624db5b311b 100644

--- a/build-v8.cmd

+++ b/build-v8.cmd

@@ -4,17 +4,15 @@ SETLOCAL

rem %1 - MSBuildBinPath, e.g. c:\Program Files (x86)\MSBuild\14.0\Bin

rem %2 - arch {ia32, x64}

rem %3 - configuration {Release, Debug}

-rem %4 - platform toolset, e.g. v140

set MsBuildBinPath=%~1

set ARCH=%~2

set CONFIGURATION=%~3

-set PlatformToolset=%~4

pushd "%~dp0"

-@python msvs_gyp_wrapper.py --depth=build\%ARCH%\v8 -f msvs -I build-v8.gypi --generator-output=build\%ARCH%\v8 -G msvs_version=2015 -Dtarget_arch=%ARCH% -Dhost_arch=%ARCH% third_party/v8/src/v8.gyp

+@python msvs_gyp_wrapper.py --depth=build\%ARCH%\v8 -f msvs -I build-v8.gypi --generator-output=build\%ARCH%\v8 -G msvs_version=2017 -Dtarget_arch=%ARCH% -Dhost_arch=%ARCH% third_party/v8/src/v8.gyp

-@"%MSBuildBinPath%/msbuild.exe" /m build/%ARCH%/v8/third_party/v8/src/v8.sln /p:PlatformToolset=%PlatformToolset% /p:Configuration=%CONFIGURATION% /target:v8_snapshot,v8_libplatform,v8_libsampler

+@"%MSBuildBinPath%/msbuild.exe" /m build/%ARCH%/v8/third_party/v8/src/v8.sln /p:Configuration=%CONFIGURATION% /target:v8_snapshot,v8_libplatform,v8_libsampler

popd

« no previous file with comments | « appveyor.yml ('k') | build-v8.gypi » ('j') | no next file with comments »