Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code

Unified Diff: lib/requestBlocker.js

Issue 29750566: Issue 6565 - Ensure the URL is known for requests we might block (Closed)
Patch Set: Created April 12, 2018, 11:51 a.m.
Use n/p to move between diff chunks; N/P to move between comments.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: lib/requestBlocker.js
diff --git a/lib/requestBlocker.js b/lib/requestBlocker.js
index 025f152f1ba605d1c5b6a6b98d5924e9654c8b81..ce60334a98e1559c594e99e76c48a7f23bfc64ba 100644
--- a/lib/requestBlocker.js
+++ b/lib/requestBlocker.js
@@ -151,7 +151,7 @@ browser.webRequest.onBeforeRequest.addListener(details =>
let frame = null;
if (details.tabId != -1)
{
- page = new ext.Page({id: details.tabId});
+ page = new ext.Page({id: details.tabId, url: details.url});
Sebastian Noack 2018/04/12 13:27:09 Shouldn't this be rather the originUrl than the ur
Sebastian Noack 2018/04/12 13:38:09 However, if no originUrl is given these request sh
kzar 2018/04/13 15:36:37 Yea, unfortunately I can.
kzar 2018/04/13 15:36:37 Yea, good point. Well since we now know why you co
Sebastian Noack 2018/04/14 03:21:26 How do I get that new tab page?
frame = ext.getFrame(
details.tabId,
// We are looking for the frame that contains the element which
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld