Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(100)

Issue 29751598: Issue 6291 - Use client certificate for Windows Store uploads (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
3 months ago by tlucas
Modified:
2 months, 2 weeks ago
Base URL:
https://hg.adblockplus.org/abpssembly/file/a67d8f0e66b2
Visibility:
Public.

Description

Issue 6291 - Use client certificate for Windows Store uploads NOTE: sitescripts.ini in abp-builds-1 needs to be updated before this lands, a hub-ticket will be created for this in-between the LGTM's and landing this, containing the following content: * add values `abpedge_privateKey` and `abpedge_thumbprint` -> the private key has to be created by someone with the corresponding permissions @ Azure AD, the thumbprint is returned by Azure AD's upload interface (see https://docs.microsoft.com/en-us/azure/active-directory/develop/active-directory-certificate-credentials ) * Copy the privateKey to the above configured path

Patch Set 1 #

Total comments: 21

Patch Set 2 : #

Total comments: 6

Patch Set 3 : #

Patch Set 4 : #

Patch Set 5 : NOISSUE rebase against https://codereview.adblockplus.org/29753611/ #

Total comments: 6

Patch Set 6 : Addressing non-functional nits #

Patch Set 7 : NO CHANGE rebase against https://codereview.adblockplus.org/29756646/ #

Unified diffs Side-by-side diffs Delta from patch set Stats (+87 lines, -35 lines) Patch
M sitescripts/extensions/bin/createNightlies.py View 1 2 3 4 5 6 8 chunks +85 lines, -35 lines 0 comments Download
M sitescripts/extensions/utils.py View 1 2 3 4 5 6 1 chunk +2 lines, -0 lines 0 comments Download

Messages

Total messages: 19
tlucas
Patch Set 1 * Replaced refresh_token authentication for the Windows store with client certificate authentication ...
3 months ago (2018-04-13 13:06:04 UTC) #1
Sebastian Noack
https://codereview.adblockplus.org/29751598/diff/29751599/sitescripts/extensions/bin/createNightlies.py File sitescripts/extensions/bin/createNightlies.py (right): https://codereview.adblockplus.org/29751598/diff/29751599/sitescripts/extensions/bin/createNightlies.py#newcode360 sitescripts/extensions/bin/createNightlies.py:360: if self.config.type in {'safari', 'edge'}: On 2018/04/13 13:06:04, tlucas ...
3 months ago (2018-04-14 02:47:30 UTC) #2
tlucas
https://codereview.adblockplus.org/29751598/diff/29751599/sitescripts/extensions/bin/createNightlies.py File sitescripts/extensions/bin/createNightlies.py (right): https://codereview.adblockplus.org/29751598/diff/29751599/sitescripts/extensions/bin/createNightlies.py#newcode360 sitescripts/extensions/bin/createNightlies.py:360: if self.config.type in {'safari', 'edge'}: On 2018/04/14 02:47:30, Sebastian ...
3 months ago (2018-04-14 08:55:46 UTC) #3
Sebastian Noack
https://codereview.adblockplus.org/29751598/diff/29751599/sitescripts/extensions/bin/createNightlies.py File sitescripts/extensions/bin/createNightlies.py (right): https://codereview.adblockplus.org/29751598/diff/29751599/sitescripts/extensions/bin/createNightlies.py#newcode360 sitescripts/extensions/bin/createNightlies.py:360: if self.config.type in {'safari', 'edge'}: On 2018/04/14 08:55:46, tlucas ...
3 months ago (2018-04-14 09:40:54 UTC) #4
Oleksandr
https://codereview.adblockplus.org/29751598/diff/29751599/sitescripts/extensions/bin/createNightlies.py File sitescripts/extensions/bin/createNightlies.py (right): https://codereview.adblockplus.org/29751598/diff/29751599/sitescripts/extensions/bin/createNightlies.py#newcode360 sitescripts/extensions/bin/createNightlies.py:360: if self.config.type in {'safari', 'edge'}: On 2018/04/14 09:40:54, Sebastian ...
3 months ago (2018-04-16 04:37:07 UTC) #5
Sebastian Noack
https://codereview.adblockplus.org/29751598/diff/29751599/sitescripts/extensions/bin/createNightlies.py File sitescripts/extensions/bin/createNightlies.py (right): https://codereview.adblockplus.org/29751598/diff/29751599/sitescripts/extensions/bin/createNightlies.py#newcode360 sitescripts/extensions/bin/createNightlies.py:360: if self.config.type in {'safari', 'edge'}: On 2018/04/16 04:37:07, Oleksandr ...
3 months ago (2018-04-16 05:45:51 UTC) #6
Sebastian Noack
https://codereview.adblockplus.org/29751598/diff/29751599/sitescripts/extensions/bin/createNightlies.py File sitescripts/extensions/bin/createNightlies.py (right): https://codereview.adblockplus.org/29751598/diff/29751599/sitescripts/extensions/bin/createNightlies.py#newcode360 sitescripts/extensions/bin/createNightlies.py:360: if self.config.type in {'safari', 'edge'}: On 2018/04/16 05:45:50, Sebastian ...
3 months ago (2018-04-16 05:47:19 UTC) #7
tlucas
https://codereview.adblockplus.org/29751598/diff/29751599/sitescripts/extensions/bin/createNightlies.py File sitescripts/extensions/bin/createNightlies.py (right): https://codereview.adblockplus.org/29751598/diff/29751599/sitescripts/extensions/bin/createNightlies.py#newcode360 sitescripts/extensions/bin/createNightlies.py:360: if self.config.type in {'safari', 'edge'}: On 2018/04/16 05:47:19, Sebastian ...
3 months ago (2018-04-16 10:06:07 UTC) #8
tlucas
https://codereview.adblockplus.org/29751598/diff/29751599/sitescripts/extensions/bin/createNightlies.py File sitescripts/extensions/bin/createNightlies.py (right): https://codereview.adblockplus.org/29751598/diff/29751599/sitescripts/extensions/bin/createNightlies.py#newcode360 sitescripts/extensions/bin/createNightlies.py:360: if self.config.type in {'safari', 'edge'}: On 2018/04/16 10:06:07, tlucas ...
3 months ago (2018-04-16 10:25:15 UTC) #9
tlucas
Patch Set 2 * Use UTC-time for generating JWT * Refactor the generation of jwt's ...
3 months ago (2018-04-16 14:50:10 UTC) #10
Sebastian Noack
https://codereview.adblockplus.org/29751598/diff/29751599/sitescripts/extensions/bin/createNightlies.py File sitescripts/extensions/bin/createNightlies.py (right): https://codereview.adblockplus.org/29751598/diff/29751599/sitescripts/extensions/bin/createNightlies.py#newcode670 sitescripts/extensions/bin/createNightlies.py:670: now = datetime.datetime.now() On 2018/04/16 14:50:09, tlucas wrote: > ...
3 months ago (2018-04-16 16:13:30 UTC) #11
tlucas
Patch Set 3 * Addressed Sebastian's nits https://codereview.adblockplus.org/29751598/diff/29753579/sitescripts/extensions/bin/createNightlies.py File sitescripts/extensions/bin/createNightlies.py (right): https://codereview.adblockplus.org/29751598/diff/29753579/sitescripts/extensions/bin/createNightlies.py#newcode359 sitescripts/extensions/bin/createNightlies.py:359: self.buildNum]) On ...
3 months ago (2018-04-16 16:37:44 UTC) #12
tlucas
Patch Set 4: * Addressed previously overseen nit https://codereview.adblockplus.org/29751598/diff/29751599/sitescripts/extensions/bin/createNightlies.py File sitescripts/extensions/bin/createNightlies.py (right): https://codereview.adblockplus.org/29751598/diff/29751599/sitescripts/extensions/bin/createNightlies.py#newcode670 sitescripts/extensions/bin/createNightlies.py:670: now ...
3 months ago (2018-04-16 16:50:24 UTC) #13
Sebastian Noack
LGTM
3 months ago (2018-04-16 16:51:00 UTC) #14
Vasily Kuznetsov
Hi Tristan, I haven't looked into details of the client certificate flow but overall the ...
3 months ago (2018-04-17 17:43:54 UTC) #15
tlucas
Patch Set 6 * Addressing final, non-functional nits https://codereview.adblockplus.org/29751598/diff/29753614/sitescripts/extensions/bin/createNightlies.py File sitescripts/extensions/bin/createNightlies.py (right): https://codereview.adblockplus.org/29751598/diff/29753614/sitescripts/extensions/bin/createNightlies.py#newcode53 sitescripts/extensions/bin/createNightlies.py:53: from ...
3 months ago (2018-04-18 12:58:31 UTC) #16
Vasily Kuznetsov
On 2018/04/18 12:58:31, tlucas wrote: > Patch Set 6 > * Addressing final, non-functional nits ...
3 months ago (2018-04-18 14:41:58 UTC) #17
Sebastian Noack
Still LGTM
3 months ago (2018-04-18 14:43:26 UTC) #18
tlucas
3 months ago (2018-04-18 15:05:35 UTC) #19
On 2018/04/18 14:43:26, Sebastian Noack wrote:
> Still LGTM

Alright.

I mailed ops (+ Sebastian and Ollie) about the necessary changes on
abp-builds-1, they confirmed receival and will start doing it / contacting us
soon.

Cheers!
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld 87257f5