Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code

Issue 29752555: Noissue - Replaced mistakenly used GPL license headers with MPL (Closed)

Created:
April 14, 2018, 10:01 a.m. by Sebastian Noack
Modified:
April 14, 2018, 10:41 a.m.
Reviewers:
tlucas
Visibility:
Public.

Description

Noissue - Replaced mistakenly used GPL license headers with MPL

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+6 lines, -32 lines) Patch
M info-loader.js View 1 chunk +3 lines, -16 lines 0 comments Download
M webpack_runner.js View 1 chunk +3 lines, -16 lines 0 comments Download

Messages

Total messages: 5
Sebastian Noack
buildtools is licensed under the MPL, since August 2014, see https://intraforum.adblockplus.org/t/licensing-buildtools-under-mpl-2-0-again/587. However, apparently, webpack-runner.js and ...
April 14, 2018, 10:04 a.m. (2018-04-14 10:04:42 UTC) #1
tlucas
On 2018/04/14 10:04:42, Sebastian Noack wrote: > buildtools is licensed under the MPL, since August ...
April 14, 2018, 10:34 a.m. (2018-04-14 10:34:15 UTC) #2
tlucas
On 2018/04/14 10:04:42, Sebastian Noack wrote: > buildtools is licensed under the MPL, since August ...
April 14, 2018, 10:34 a.m. (2018-04-14 10:34:15 UTC) #3
tlucas
On 2018/04/14 10:34:15, tlucas wrote: > On 2018/04/14 10:04:42, Sebastian Noack wrote: > > buildtools ...
April 14, 2018, 10:36 a.m. (2018-04-14 10:36:02 UTC) #4
Sebastian Noack
April 14, 2018, 10:39 a.m. (2018-04-14 10:39:49 UTC) #5
On 2018/04/14 10:36:02, tlucas wrote:
> How ever this could end up as a double-post. Never the less, would mind making
> sure that this review is mentioned in the commit message's body?

Of course, I always put the URL to the review on the second line of the commit
message for Noissue patches.

Powered by Google App Engine
This is Rietveld