Delta Between Two Patch Sets: README.md
Issue 29752576:
Noissue - Added Node.js requirement to README (Closed)
Left Patch Set:
Created April 14, 2018, 7:42 p.m.
Right Patch Set: Decreased minimum Node.js version to 7
Created April 16, 2018, 8:25 a.m.
| Left: | ||
| Right: |
Use n/p to move between diff chunks;
N/P to move between comments.
« no previous file with change/comment
|
« no previous file
|
no next file »
|
no next file with change/comment »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')
| LEFT | RIGHT |
|---|---|
| 1 Adblock Plus for Chrome, Opera, Microsoft Edge and Firefox | 1 Adblock Plus for Chrome, Opera, Microsoft Edge and Firefox |
| 2 ========================================================== | 2 ========================================================== |
| 3 | 3 |
| 4 This repository contains the platform-specific Adblock Plus source code for | 4 This repository contains the platform-specific Adblock Plus source code for |
| 5 Chrome, Opera, Microsoft Edge and Firefox. It can be used to build | 5 Chrome, Opera, Microsoft Edge and Firefox. It can be used to build |
| 6 Adblock Plus for these platforms, generic Adblock Plus code will be extracted | 6 Adblock Plus for these platforms, generic Adblock Plus code will be extracted |
| 7 from other repositories automatically (see _dependencies_ file). | 7 from other repositories automatically (see _dependencies_ file). |
| 8 | 8 |
| 9 Note that the Firefox extension built from this repository is the new | 9 Note that the Firefox extension built from this repository is the new |
| 10 [WebExtension](https://developer.mozilla.org/en-US/Add-ons/WebExtensions). | 10 [WebExtension](https://developer.mozilla.org/en-US/Add-ons/WebExtensions). |
| 11 The source code of the legacy Adblock Plus extension | 11 The source code of the legacy Adblock Plus extension |
| 12 can be found [here](https://hg.adblockplus.org/adblockplus). | 12 can be found [here](https://hg.adblockplus.org/adblockplus). |
| 13 | 13 |
| 14 Building | 14 Building |
| 15 --------- | 15 --------- |
| 16 | 16 |
| 17 ### Requirements | 17 ### Requirements |
| 18 | 18 |
| 19 - [Mercurial](https://www.mercurial-scm.org/) or [Git](https://git-scm.com/) (wh ichever you used to clone this repository) | 19 - [Mercurial](https://www.mercurial-scm.org/) or [Git](https://git-scm.com/) (wh ichever you used to clone this repository) |
| 20 - [Python 2.7](https://www.python.org) | 20 - [Python 2.7](https://www.python.org) |
| 21 - [The Jinja2 module](http://jinja.pocoo.org/docs) (>= 2.8) | 21 - [The Jinja2 module](http://jinja.pocoo.org/docs) (>= 2.8) |
|
tlucas
2018/04/15 08:41:21
Just wondering, are these extra whitespaces intent
Sebastian Noack
2018/04/15 12:01:17
Yes, in order to group the Python modules under Py
| |
| 22 - For signed builds: [PyCrypto module](https://www.dlitz.net/software/pycrypto /) | 22 - For signed builds: [PyCrypto module](https://www.dlitz.net/software/pycrypto /) |
| 23 - [Node.js](https://nodejs.org/) (>= 8) | 23 - [Node.js](https://nodejs.org/) (>= 7) |
|
Sebastian Noack
2018/04/14 19:49:32
Version 8.x is the current LTS channel of Node.js.
Sebastian Noack
2018/04/16 08:27:35
As discussed with Dave on IRC, I went with Node.js
| |
| 24 | 24 |
| 25 ### Building the extension | 25 ### Building the extension |
| 26 | 26 |
| 27 Run one of the following commands in the project directory, depending on your | 27 Run one of the following commands in the project directory, depending on your |
| 28 target platform: | 28 target platform: |
| 29 | 29 |
| 30 ./build.py build -t chrome -k adblockpluschrome.pem | 30 ./build.py build -t chrome -k adblockpluschrome.pem |
| 31 ./build.py build -t edge | 31 ./build.py build -t edge |
| 32 ./build.py build -t gecko | 32 ./build.py build -t gecko |
| 33 | 33 |
| (...skipping 56 matching lines...) Expand 10 before | Expand all | Expand 10 after Loading... | |
| 90 Linting | 90 Linting |
| 91 ------- | 91 ------- |
| 92 | 92 |
| 93 You can lint the code using [ESLint](http://eslint.org). | 93 You can lint the code using [ESLint](http://eslint.org). |
| 94 | 94 |
| 95 eslint *.js lib/ qunit/ ext/ chrome/ | 95 eslint *.js lib/ qunit/ ext/ chrome/ |
| 96 | 96 |
| 97 You will need to set up ESLint and our configuration first, see | 97 You will need to set up ESLint and our configuration first, see |
| 98 [eslint-config-eyeo](https://hg.adblockplus.org/codingtools/file/tip/eslint-conf ig-eyeo) | 98 [eslint-config-eyeo](https://hg.adblockplus.org/codingtools/file/tip/eslint-conf ig-eyeo) |
| 99 for more information. | 99 for more information. |
| LEFT | RIGHT |
« no previous file
|
no next file »
|
Toggle Intra-line Diffs ('i')
|
Expand Comments ('e')
|
Collapse Comments ('c')
|
Toggle Comments ('s')
