Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code
Issues
All Issues

Issue 29752576: Noissue - Added Node.js requirement to README (Closed)

Created:
April 14, 2018, 7:42 p.m. by Sebastian Noack
Modified:
April 16, 2018, 9 a.m.
Reviewers:
tlucas
CC:
kzar
Visibility:
Public.

Description

Noissue - Added Node.js requirement to README

Patch Set 1 #

Total comments: 4

Patch Set 2 : Decreased minimum Node.js version to 7 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -2 lines) Patch
M README.md View 1 1 chunk +3 lines, -2 lines 0 comments Download

Messages

Total messages: 5
Sebastian Noack
https://codereview.adblockplus.org/29752576/diff/29752577/README.md File README.md (right): https://codereview.adblockplus.org/29752576/diff/29752577/README.md#newcode23 README.md:23: - [Node.js](https://nodejs.org/) (>= 8) Version 8.x is the current ...
April 14, 2018, 7:49 p.m. (2018-04-14 19:49:32 UTC) #1
tlucas
https://codereview.adblockplus.org/29752576/diff/29752577/README.md File README.md (right): https://codereview.adblockplus.org/29752576/diff/29752577/README.md#newcode21 README.md:21: - [The Jinja2 module](http://jinja.pocoo.org/docs) (>= 2.8) Just wondering, are ...
April 15, 2018, 8:41 a.m. (2018-04-15 08:41:22 UTC) #2
Sebastian Noack
https://codereview.adblockplus.org/29752576/diff/29752577/README.md File README.md (right): https://codereview.adblockplus.org/29752576/diff/29752577/README.md#newcode21 README.md:21: - [The Jinja2 module](http://jinja.pocoo.org/docs) (>= 2.8) On 2018/04/15 08:41:21, ...
April 15, 2018, 12:01 p.m. (2018-04-15 12:01:17 UTC) #3
Sebastian Noack
https://codereview.adblockplus.org/29752576/diff/29752577/README.md File README.md (right): https://codereview.adblockplus.org/29752576/diff/29752577/README.md#newcode23 README.md:23: - [Node.js](https://nodejs.org/) (>= 8) On 2018/04/14 19:49:32, Sebastian Noack ...
April 16, 2018, 8:27 a.m. (2018-04-16 08:27:36 UTC) #4
tlucas
April 16, 2018, 8:36 a.m. (2018-04-16 08:36:09 UTC) #5 
On 2018/04/16 08:27:36, Sebastian Noack wrote:
> https://codereview.adblockplus.org/29752576/diff/29752577/README.md
> File README.md (right):
> 
> https://codereview.adblockplus.org/29752576/diff/29752577/README.md#newcode23
> README.md:23: - [Node.js](https://nodejs.org/) (>= 8)
> On 2018/04/14 19:49:32, Sebastian Noack wrote:
> > Version 8.x is the current LTS channel of Node.js. I'm on version 8.5.0
which
> > buildtools is compatible with. If any of you have any more accurate
> information
> > regarding the minimum Node.js version required, please let me know.
> 
> As discussed with Dave on IRC, I went with Node.js >=7 now.
> For reference, this is what we require for adblockpluscore.

LGTM

Powered by Google App Engine
This is Rietveld