Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code

Unified Diff: README.md

Issue 29752576: Noissue - Added Node.js requirement to README (Closed)
Patch Set: Created April 14, 2018, 7:42 p.m.
Use n/p to move between diff chunks; N/P to move between comments.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: README.md
===================================================================
--- a/README.md
+++ b/README.md
@@ -18,8 +18,9 @@
- [Mercurial](https://www.mercurial-scm.org/) or [Git](https://git-scm.com/) (whichever you used to clone this repository)
- [Python 2.7](https://www.python.org)
-- [The Jinja2 module](http://jinja.pocoo.org/docs) (>= 2.8)
-- For signed builds: [PyCrypto module](https://www.dlitz.net/software/pycrypto/)
+ - [The Jinja2 module](http://jinja.pocoo.org/docs) (>= 2.8)
tlucas 2018/04/15 08:41:21 Just wondering, are these extra whitespaces intent
Sebastian Noack 2018/04/15 12:01:17 Yes, in order to group the Python modules under Py
+ - For signed builds: [PyCrypto module](https://www.dlitz.net/software/pycrypto/)
+- [Node.js](https://nodejs.org/) (>= 8)
Sebastian Noack 2018/04/14 19:49:32 Version 8.x is the current LTS channel of Node.js.
Sebastian Noack 2018/04/16 08:27:35 As discussed with Dave on IRC, I went with Node.js
### Building the extension
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld