Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code

Side by Side Diff: sitescripts/send_installation_link/web/send_installation_link.py

Issue 29756624: Noissue - Adapt best practices for trailing commas (sitescripts) (Closed)
Patch Set: Re-run script on Python 2, added flake8-commas extension Created April 19, 2018, 2:35 p.m.
Left:
Right:
Use n/p to move between diff chunks; N/P to move between comments.
Jump to:
View unified diff | Download patch
« no previous file with comments | « sitescripts/reports/bin/updateDigests.py ('k') | sitescripts/stats/bin/logprocessor.py » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 # This file is part of the Adblock Plus web scripts, 1 # This file is part of the Adblock Plus web scripts,
2 # Copyright (C) 2006-present eyeo GmbH 2 # Copyright (C) 2006-present eyeo GmbH
3 # 3 #
4 # Adblock Plus is free software: you can redistribute it and/or modify 4 # Adblock Plus is free software: you can redistribute it and/or modify
5 # it under the terms of the GNU General Public License version 3 as 5 # it under the terms of the GNU General Public License version 3 as
6 # published by the Free Software Foundation. 6 # published by the Free Software Foundation.
7 # 7 #
8 # Adblock Plus is distributed in the hope that it will be useful, 8 # Adblock Plus is distributed in the hope that it will be useful,
9 # but WITHOUT ANY WARRANTY; without even the implied warranty of 9 # but WITHOUT ANY WARRANTY; without even the implied warranty of
10 # MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the 10 # MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
11 # GNU General Public License for more details. 11 # GNU General Public License for more details.
12 # 12 #
13 # You should have received a copy of the GNU General Public License 13 # You should have received a copy of the GNU General Public License
14 # along with Adblock Plus. If not, see <http://www.gnu.org/licenses/>. 14 # along with Adblock Plus. If not, see <http://www.gnu.org/licenses/>.
15 15
16 from sitescripts.utils import get_config, sendMail, encode_email_address 16 from sitescripts.utils import get_config, sendMail, encode_email_address
17 from sitescripts.web import url_handler, form_handler, send_simple_response 17 from sitescripts.web import url_handler, form_handler, send_simple_response
18 18
19 19
20 @url_handler('/sendInstallationLink') 20 @url_handler('/sendInstallationLink')
21 @form_handler 21 @form_handler
22 def send_installation_link(environ, start_response, data): 22 def send_installation_link(environ, start_response, data):
23 email = data.get('email', '').strip() 23 email = data.get('email', '').strip()
24 try: 24 try:
25 email = encode_email_address(email) 25 email = encode_email_address(email)
26 except ValueError: 26 except ValueError:
27 return send_simple_response( 27 return send_simple_response(
28 start_response, 400, 28 start_response, 400,
29 'Please enter a valid email address.' 29 'Please enter a valid email address.',
30 ) 30 )
31 31
32 config = get_config() 32 config = get_config()
33 template_path = config.get('send_installation_link', 'email_template') 33 template_path = config.get('send_installation_link', 'email_template')
34 sendMail(template_path, {'recipient': email}) 34 sendMail(template_path, {'recipient': email})
35 35
36 return send_simple_response( 36 return send_simple_response(
37 start_response, 200, 37 start_response, 200,
38 'The app is on the way! ' 38 'The app is on the way! '
39 'Please check your email on your smartphone or tablet.' 39 'Please check your email on your smartphone or tablet.',
40 ) 40 )
OLDNEW
« no previous file with comments | « sitescripts/reports/bin/updateDigests.py ('k') | sitescripts/stats/bin/logprocessor.py » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld