Noissue - Adapt best practices for trailing commas (sitescripts)

Noissue - Adapt best practices for trailing commas

[Sebastian Noack, 2018-04-19 12:46:35]

These changes were auto-generated with following script (flake8-commas
required):

  import sys
  import subprocess
  MISSING_COMMA = {'C812', 'C813', 'C814', 'C815', 'C816'}
  BAD_COMMA = {'C818', 'C819'}
  COMMA_ERRORS = MISSING_COMMA | BAD_COMMA

  output = subprocess.Popen(['flake8', '--'] + sys.argv[1:],
                            stdout=subprocess.PIPE,
                            universal_newlines=True).communicate()[0]

  files = {}
  for line in output.splitlines():
      filename, lineno, colno, message = line.split(':', 3)
      error = message.split()[0]
      if error in COMMA_ERRORS:
          files.setdefault(filename, {})[(int(lineno), int(colno))] = error

  for filename, errors in files.items():
      with open(filename, 'r+') as file:
          data = file.read()
          lineno = 1
          colno = 0
          i = 0
          while i < len(data):
              if data[i] == '\n':
                  lineno += 1
                  colno = 0
              else:
                  colno += 1

              error = errors.get((lineno, colno + 1))
              if error:
                  if error in MISSING_COMMA:
                      data = '{},{}'.format(data[:i + 1], data[i + 1:])
                      i += 2
                  elif error in BAD_COMMA:
                      data = data[:i] + data[i + 1:]
              else:
                  i += 1

          file.seek(0)
          file.write(data)
          file.truncate()

For reference, the corresponding style guide change:
https://hg.adblockplus.org/web.adblockplus.org/rev/de9a87cab68b#l1.42

[Sebastian Noack, 2018-04-19 14:37:45]

After re-running my script with Python 2, flake8-commas found some more missing
commas. Also I added the flake8-commas extension to the tox.ini.

[Vasily Kuznetsov, 2018-04-19 15:15:26]

LGTM