sitescripts/extensions/utils.py - Issue 29756624: Noissue - Adapt best practices for trailing commas (sitescripts)

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Unified Diff: sitescripts/extensions/utils.py

Issue 29756624: Noissue - Adapt best practices for trailing commas (sitescripts) (Closed)

Patch Set: Re-run script on Python 2, added flake8-commas extension Created April 19, 2018, 2:35 p.m.

Use n/p to move between diff chunks; N/P to move between comments.

Jump to:

Index: sitescripts/extensions/utils.py

===================================================================

--- a/sitescripts/extensions/utils.py

+++ b/sitescripts/extensions/utils.py

@@ -36,7 +36,7 @@

'safari': '.safariextz',

'ie': '.exe',

'android': '.apk',

- 'edge': '.appx'

+ 'edge': '.appx',

}

@@ -379,11 +379,11 @@

version = extension['version']

updates['%s/%s' % (basename, 'msie64')] = {

'url': updateURL.replace('.exe', '-x64.msi'),

- 'version': version

+ 'version': version,

}

updates['%s/%s' % (basename, 'msie32')] = {

'url': updateURL.replace('.exe', '-x86.msi'),

- 'version': version

+ 'version': version,

}

writeLibabpUpdateManifest(path, updates)

@@ -400,6 +400,6 @@

for extension in extensions:

updates[extension['basename']] = {

'url': extension['updateURL'],

- 'version': extension['version']

+ 'version': extension['version'],

}

writeLibabpUpdateManifest(path, updates)