sitescripts/hg/test/update_issues.py - Issue 29756624: Noissue - Adapt best practices for trailing commas (sitescripts)

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Unified Diff: sitescripts/hg/test/update_issues.py

Issue 29756624: Noissue - Adapt best practices for trailing commas (sitescripts) (Closed)

Patch Set: Re-run script on Python 2, added flake8-commas extension Created April 19, 2018, 2:35 p.m.

Use n/p to move between diff chunks; N/P to move between comments.

Jump to:

Index: sitescripts/hg/test/update_issues.py

===================================================================

--- a/sitescripts/hg/test/update_issues.py

+++ b/sitescripts/hg/test/update_issues.py

@@ -23,7 +23,7 @@

def _issue(component, milestone='', can_resolve=False):

issue = {

'attrs': {'_ts': 1, 'milestone': milestone, 'component': component},

- 'actions': [['leave', '', '', []]]

+ 'actions': [['leave', '', '', []]],

}

if can_resolve:

issue['actions'].append(['resolve', '', '', []])

@@ -35,13 +35,13 @@

2448: _issue(component='two'),

3559: _issue(component='one', milestone='other'),

4670: _issue(component='three', can_resolve=True),

- 5781: _issue(component='four', can_resolve=True)

+ 5781: _issue(component='four', can_resolve=True),

}

MILESTONES = {

'completed': {'completed': True, 'name': 'completed'},

'current': {'completed': None, 'name': 'current'},

- 'other': {'completed': None, 'name': 'other'}

+ 'other': {'completed': None, 'name': 'other'},

}

@@ -129,7 +129,7 @@

'Issue 1337: Colon instead of dash',

'Noissue no dash',

'Issue 1337-No space around dash',

- 'Fixes 1337 no dash'

+ 'Fixes 1337 no dash',

], warning_count=7)

def test_noissue_commits_ignored(self):

« no previous file with comments | « sitescripts/hg/bin/update_issues.py ('k') | sitescripts/management/bin/generateHgAuth.py » ('j') | no next file with comments »