Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code

Unified Diff: sitescripts/extensions/bin/updateUpdateManifests.py

Issue 29756646: Noissue - Adapt best practices for trailing commas (abpssembly) (Closed)
Patch Set: Re-run script on Python 2, added flake8-commas extension Created April 19, 2018, 2:41 p.m.
Use n/p to move between diff chunks; N/P to move between comments.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « sitescripts/extensions/bin/updateRecommendations.py ('k') | sitescripts/extensions/utils.py » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: sitescripts/extensions/bin/updateUpdateManifests.py
===================================================================
--- a/sitescripts/extensions/bin/updateUpdateManifests.py
+++ b/sitescripts/extensions/bin/updateUpdateManifests.py
@@ -57,7 +57,7 @@
'revision': revision,
'version': version,
'minSdkVersion': get_min_sdk_version(repo, version),
- 'basename': os.path.basename(repo.repository)
+ 'basename': os.path.basename(repo.repository),
}
elif repo.type == 'safari':
metadata = repo.readMetadata(version)
@@ -68,12 +68,12 @@
'version': version,
'shortVersion': version,
'basename': metadata.get('general', 'basename'),
- 'updatedFromGallery': True
+ 'updatedFromGallery': True,
}
elif repo.type == 'ie':
return {
'version': version,
- 'basename': os.path.basename(repo.repository)
+ 'basename': os.path.basename(repo.repository),
}
else:
raise Exception('unknown repository type %r' % repo.type)
« no previous file with comments | « sitescripts/extensions/bin/updateRecommendations.py ('k') | sitescripts/extensions/utils.py » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld